← Back to team overview

dhis2-devs-core team mailing list archive

Re: merge apps

 

This is done in trunk now.


On Tue, Aug 5, 2014 at 6:12 PM, Lars Helge Øverland <larshelge@xxxxxxxxx>
wrote:

> Note that this is only for the following apps:
>
> dhis-web-event-capture
> dhis-web-event-reports
> dhis-web-event-visualizer
> dhis-web-visualizer
> dhis-web-mapping
> dhis-web-pivot
> dhis-web-tracker-capture
>
>
>
>
> On Tue, Aug 5, 2014 at 5:47 PM, Jan Henrik Øverland <
> janhenrik.overland@xxxxxxxxx> wrote:
>
>> Ok. And I can do the merging. Would be great if everyone cleaned up their
>> i18n files first as well as they tend to have a lot of unused entries.
>>  On Aug 5, 2014 5:13 PM, "Lars Helge Øverland" <larshelge@xxxxxxxxx>
>> wrote:
>>
>>> OK good then let's do it. I have written up a blueprint for the i18n
>>> client side solution here for Jan:
>>>
>>> https://blueprints.launchpad.net/dhis2/+spec/analysis-client-side-i18n
>>>
>>> It actually also depends on Jan removing all action classes from GIS and
>>> replaces them with use of the Web API.
>>>
>>>
>>>
>>>
>>> On Tue, Jul 29, 2014 at 2:02 PM, Morten Olav Hansen <mortenoh@xxxxxxxxx>
>>> wrote:
>>>
>>>> Yes, I think we should do this. Could we at the same time agree on a
>>>> file structure, so it will be easier in the future to do automatic
>>>> uglyfying etc (I think there is a blueprint for this already?).
>>>>
>>>> --
>>>> Morten
>>>>
>>>>
>>>> On Sat, Jul 26, 2014 at 8:53 PM, Jan Henrik Øverland <
>>>> janhenrik.overland@xxxxxxxxx> wrote:
>>>>
>>>>> +1
>>>>> On Jul 26, 2014 12:01 PM, "Lars Helge Øverland" <larshelge@xxxxxxxxx>
>>>>> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> we now have a fair number of open web apps (7) and there isn't really
>>>>>> a need to have a separate maven project for each. Should we simply merge
>>>>>> all apps (visualizer, tracker capture, etc) into a single maven project
>>>>>> called dhis-web-apps ? It would look like this:
>>>>>>
>>>>>> dhis-web-apps/
>>>>>>   src/main/resources/
>>>>>>   src/main/resources/struts.xml
>>>>>>   src/main/resources/org/hisp/dhis/apps/i18n_module.properties
>>>>>>   src/main/webapp/
>>>>>>   src/main/webapp/dhis-web-visualizer
>>>>>>   src/main/webapp/dhis-web-pivot
>>>>>>   src/main/webapp/dhis-web-tracker-capture
>>>>>>   src/main/webapp/dhis-web-event-capture
>>>>>>   etc..
>>>>>>
>>>>>> It would require that we
>>>>>>
>>>>>> - merge the struts.xml files, and have multiple packages in the same
>>>>>> file (works well)
>>>>>> - merge the i18n_module.properties keys for the Ext-based apps, or
>>>>>> better, find a client-side solution for translations also for the Ext-based
>>>>>> apps
>>>>>>
>>>>>> Otherwise we don't lose much.
>>>>>>
>>>>>> The benefits are:
>>>>>>
>>>>>> - shorter build time of dhis-web
>>>>>> - less stop and start, as you can use mvn jetty:plugin and serve all
>>>>>> apps, allowing you to fix things/test/set up stuff in all of them without
>>>>>> restarting the container
>>>>>>
>>>>>> Eventually, when all modules have become apps, we will only have one
>>>>>> maven project, and the build problem is gone. What do you think?
>>>>>>
>>>>>> Lars
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Mailing list: https://launchpad.net/~dhis2-devs-core
>>>>>> Post to     : dhis2-devs-core@xxxxxxxxxxxxxxxxxxx
>>>>>> Unsubscribe : https://launchpad.net/~dhis2-devs-core
>>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>>
>>>>>>
>>>>> --
>>>>> Mailing list: https://launchpad.net/~dhis2-devs-core
>>>>> Post to     : dhis2-devs-core@xxxxxxxxxxxxxxxxxxx
>>>>> Unsubscribe : https://launchpad.net/~dhis2-devs-core
>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>
>>>>>
>>>>
>>>
>

Follow ups

References