← Back to team overview

dhis2-devs-core team mailing list archive

Re: App translation file names

 

Sounds good. Yes lets keep have a common approach for building / loading
the translation files - its more maintainable that each app having their
own approach.

On Mon, Nov 24, 2014 at 9:27 AM, Abyot Gizaw <abyota@xxxxxxxxx> wrote:

> Hi Mark,
>
> Yes sure. I am thinking of a provider that wraps $translateProvider and be
> injected during app initialization.
>
> ---
> Thank you,
> Abyot.
>
> On Fri, Nov 21, 2014 at 1:33 PM, Mark Polak <markpo@xxxxxxxxxx> wrote:
>
>> Hey Abyot,
>>
>> I’m sure this stuff will need to be reused more often in all of the other
>> apps that we will move to angular.
>>
>> I assume you will create a custom loader for the translate module.
>>
>> The custom loader could fetch the properties file and then use Jan his
>> parser to translate it to JSON.
>>
>> If you could create this custom loader in a separate angular module that
>> would be great, then we could reuse it easily in the future.
>>
>> Kind regards,
>>
>> Mark Polak
>> mark@xxxxxxxxxxxxxxx
>> markpo@xxxxxxxxxx
>> +47 970 36 752
>>
>> On 21 Nov 2014, at 13:28, Jason Pickering <jason.p.pickering@xxxxxxxxx>
>> wrote:
>>
>> Great.  You can use the current naming convention for now.  I am working
>> with the development team of the translation software to try and work out
>> the other issues. Thanks!
>> On Nov 21, 2014 1:19 PM, "Abyot Gizaw" <abyota@xxxxxxxxx> wrote:
>>
>>> I can now work to fix the translation file with the event/tracker
>>> capture apps. What is the file name convention you guys decided? Shall I
>>> follow Jan's naming convention?
>>>
>>>
>>> ---
>>> Thank you,
>>> Abyot.
>>>
>>> On Thu, Nov 20, 2014 at 2:14 PM, Jason Pickering <
>>> jason.p.pickering@xxxxxxxxx> wrote:
>>>
>>>> Before you do this..just wait. I finally managed to get in touch with a
>>>> human behind that Pootle project, and they may fix it for us.
>>>>
>>>> So, for the time being, we can wait, but thanks for agreeing to the
>>>> change. I will let you know. Good to know it can be changed quickly if
>>>> needed.
>>>>
>>>> On Thu, Nov 20, 2014 at 2:12 PM, Jan Henrik Øverland <
>>>> janhenrik.overland@xxxxxxxxx> wrote:
>>>>
>>>>> Ok, I will change all the existing translation files in my apps to
>>>>> "apps".
>>>>>
>>>>> On Thu, Nov 20, 2014 at 1:40 PM, Abyot Gizaw <abyota@xxxxxxxxx> wrote:
>>>>>
>>>>>> As I tried to mention this last time, the plugin I have for angular
>>>>>> translation accepts only JSON file not properties. I will look for a
>>>>>> solution to accept properties file. I know it has been a while since this
>>>>>> was asked ... but I need more time to fix this.
>>>>>>
>>>>>>
>>>>>> ---
>>>>>> Thank you,
>>>>>> Abyot.
>>>>>>
>>>>>> On Thu, Nov 6, 2014 at 2:27 PM, Jan Henrik Øverland <
>>>>>> janhenrik.overland@xxxxxxxxx> wrote:
>>>>>>
>>>>>>> Abyot, I can see you are still using json files. You can convert
>>>>>>> properties files to json objects with the dhis2.util.parseJavaProperties
>>>>>>> function.
>>>>>>>
>>>>>>> On Thu, Nov 6, 2014 at 1:34 PM, Jan Henrik Øverland <
>>>>>>> janhenrik.overland@xxxxxxxxx> wrote:
>>>>>>>
>>>>>>>> Sure, it will just take a minute to change it so why not.
>>>>>>>>
>>>>>>>> Then lets go for
>>>>>>>>
>>>>>>>> i18n_app.properties
>>>>>>>> i18n_app_es.properties
>>>>>>>> etc
>>>>>>>>
>>>>>>>> On Thu, Nov 6, 2014 at 1:25 PM, Jason Pickering <
>>>>>>>> jason.p.pickering@xxxxxxxxx> wrote:
>>>>>>>>
>>>>>>>>> Yeah, i guess what I was asking for would be that the name of the
>>>>>>>>> template (English) correspond to the pattern similar to the rest of the
>>>>>>>>> application.
>>>>>>>>>
>>>>>>>>> The path itself is fine. it is really just the file name which is
>>>>>>>>> important to the translation server engine. It recognizes the template
>>>>>>>>> files as "somepattern".properties and translation files as
>>>>>>>>> "somepattern_Language".properties, if that makes sense. The problem now, is
>>>>>>>>> it does not recognize the template but sees "en.properties" as a separate
>>>>>>>>> language. So similar to the "i18n_modules.properites"  (which it recognizes
>>>>>>>>> as a template. Note the lack of "en" in the file name)  and
>>>>>>>>> "i18n_module_es.properties" as a Spanish translation of the template.
>>>>>>>>>
>>>>>>>>> I know it is quirky, but hope it makes sense?
>>>>>>>>>
>>>>>>>>> Regards,
>>>>>>>>> Jason
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Thu, Nov 6, 2014 at 1:20 PM, Jan Henrik Øverland <
>>>>>>>>> janhenrik.overland@xxxxxxxxx> wrote:
>>>>>>>>>
>>>>>>>>>> Hi Jason,
>>>>>>>>>>
>>>>>>>>>> the apps in dhis-web-apps have the structure i18n/en.properties
>>>>>>>>>> etc where the "en" is the default file.
>>>>>>>>>>
>>>>>>>>>> Should I change this?
>>>>>>>>>>
>>>>>>>>>> On Thu, Nov 6, 2014 at 9:48 AM, Jason Pickering <
>>>>>>>>>> jason.p.pickering@xxxxxxxxx> wrote:
>>>>>>>>>>
>>>>>>>>>>> Due to some peculiarities of the the software which is being
>>>>>>>>>>> used by some people to translate DHIS2 (
>>>>>>>>>>> http://translate.dhis2.net), the template files for all apps
>>>>>>>>>>> are not being recognized, thus it is currently not possible to translate
>>>>>>>>>>> them through this method. Would it be possible to use a similar file name
>>>>>>>>>>> structure as the rest of the application, so something like
>>>>>>>>>>>
>>>>>>>>>>> 1) i18_app.properties (for the English template)
>>>>>>>>>>> 2)  i18_app_es.properties (for the Spanish translation)
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> This would really help out the translation process,but not sure
>>>>>>>>>>> if there would be reasons not to do this?
>>>>>>>>>>>
>>>>>>>>>>> Regards
>>>>>>>>>>> Jason
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>>> Jason P. Pickering
>>>>>>>>>>> email: jason.p.pickering@xxxxxxxxx
>>>>>>>>>>> tel:+46764147049
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>>> Mailing list: https://launchpad.net/~dhis2-devs-core
>>>>>>>>>>> Post to     : dhis2-devs-core@xxxxxxxxxxxxxxxxxxx
>>>>>>>>>>> Unsubscribe : https://launchpad.net/~dhis2-devs-core
>>>>>>>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Jason P. Pickering
>>>>>>>>> email: jason.p.pickering@xxxxxxxxx
>>>>>>>>> tel:+46764147049
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Jason P. Pickering
>>>> email: jason.p.pickering@xxxxxxxxx
>>>> tel:+46764147049
>>>>
>>>
>>>  --
>> Mailing list: https://launchpad.net/~dhis2-devs-core
>> Post to     : dhis2-devs-core@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~dhis2-devs-core
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>>
>
> --
> Mailing list: https://launchpad.net/~dhis2-devs-core
> Post to     : dhis2-devs-core@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~dhis2-devs-core
> More help   : https://help.launchpad.net/ListHelp
>
>

References