dhis2-devs-core team mailing list archive

[Morten Olav Hansen <mortenoh@xxxxxxxxx>]

Great, thanks

--
Morten

On Fri, Jul 3, 2015 at 2:18 PM, Abyot Gizaw <abyota@xxxxxxxxx> wrote:

> Yes, tracker-capture in trunk is already update
> to /api/trackedEntityInstances/query
>
> On Fri, Jul 3, 2015 at 9:09 AM Morten Olav Hansen <mortenoh@xxxxxxxxx>
> wrote:
>
>> Hi
>>
>> Is it ok that I commit this code now? did you update tracker* apps?
>>
>> --
>> Morten
>>
>> On Mon, Jun 29, 2015 at 3:23 PM, Abyot Gizaw <abyota@xxxxxxxxx> wrote:
>>
>>> ok fine ... let's keep api/trackedEntiyInstances/query.
>>>
>>>
>>> On Mon, Jun 29, 2015 at 10:16 AM Morten Olav Hansen <mortenoh@xxxxxxxxx>
>>> wrote:
>>>
>>>> Yes, I have tested this and it works. But I thought this is going to be
>>>>> soon replaced. Or are you going to keep it?
>>>>>
>>>>
>>>> We haven't decided on that yet, for now at least we don't want to break
>>>> anything (except changing the endpoint). I'm not sure why Lars decided to
>>>> go with the grid format to start with, but I'm sure he had good reasons (he
>>>> replaced the dxf2 tei object we had there before), there might also be
>>>> performance gains by using the /query methods, since it will be using SQL
>>>> instead (the new endpoint is using hibernate)
>>>>
>>>> When is implemented, the /api/trackedEntityInstances endpoint will
>>>>>> instead return Dxf2 TEI objects (same as you get when you use
>>>>>> /api/trackedEntityInstances/ID)
>>>>>>
>>>>>
>>>>> Yes, good. But what are the query parameters for
>>>>> /api/trackedEntityInstances?
>>>>>
>>>>
>>>> It will start out simple, not sure how much we can get in for 2.20. We
>>>> have something called TrackedEntityInstaneQueryParams internally which I
>>>> will try and reuse, how much of that object will be supported to start with
>>>> I'm not sure, but I would like to keep the parameters more or less exactly
>>>> the same.
>>>>
>>>> This blueprint came as a request from the Android team, as they wanted
>>>> the full object (relationships etc also), we might in 2.21 also include
>>>> enrollments/events in the same object as it makes sense if you want offline
>>>> the full data of some TEIs.
>>>>
>>>> --
>>>> Morten
>>>>
>>>>
>>>>>
>>>>>
>>>>
>>>>>> --
>>>>>> Morten
>>>>>>
>>>>>> On Mon, Jun 29, 2015 at 2:37 PM, Abyot Gizaw <abyota@xxxxxxxxx>
>>>>>> wrote:
>>>>>>
>>>>>>> Hi Morten,
>>>>>>>
>>>>>>> Yes, this affects any tracker related app - definitely
>>>>>>> tracker-capture. But what are the query parameters? Are you going to keep
>>>>>>> existing format?
>>>>>>>
>>>>>>> Thank you,
>>>>>>> Abyot.
>>>>>>>
>>>>>>> On Mon, Jun 29, 2015 at 5:58 AM Morten Olav Hansen <
>>>>>>> mortenoh@xxxxxxxxx> wrote:
>>>>>>>
>>>>>>>> Hi guys
>>>>>>>>
>>>>>>>> As part of this [1] I have changed the TEI query endpoint a bit,
>>>>>>>> for -now- it can be accessed as before on /api/trackedEntityInstances/, but
>>>>>>>> I have also made it available on /api/trackedEntityInstances/query (its new
>>>>>>>> location)
>>>>>>>>
>>>>>>>> Please guys, update your config (I have also updated 2.19 to
>>>>>>>> support both endpoints), in a day or two the /api/trackedEntityInstances/
>>>>>>>> endpoint will be replaced with proper TEI objects (from dxf2) and not the
>>>>>>>> grid as we have today (it will just be available as /query)
>>>>>>>>
>>>>>>>> I think this at least applies to tracker-capture (and maybe Android
>>>>>>>> app?)
>>>>>>>>
>>>>>>>> [1]
>>>>>>>> https://blueprints.launchpad.net/dhis2/+spec/web-api-tei-objects-query-resource
>>>>>>>>
>>>>>>>> --
>>>>>>>> Morten
>>>>>>>>  --
>>>>>>>> Mailing list: https://launchpad.net/~dhis2-devs-core
>>>>>>>> Post to     : dhis2-devs-core@xxxxxxxxxxxxxxxxxxx
>>>>>>>> Unsubscribe : https://launchpad.net/~dhis2-devs-core
>>>>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>>>>
>>>>>>> --
>>>>>>> ----
>>>>>>> Thank you,
>>>>>>> Abyot
>>>>>>>
>>>>>>
>>>>>> --
>>>>> ----
>>>>> Thank you,
>>>>> Abyot
>>>>>
>>>> --
>>> ----
>>> Thank you,
>>> Abyot
>>>
>>
>> --
> ----
> Thank you,
> Abyot
>