dhis2-devs-core team mailing list archive
-
dhis2-devs-core team
-
Mailing list archive
-
Message #00354
Re: dateOfIncident > incidentDate
Thanks Tran, thats good.... Please also remember to copy the list since
several of the apps will be affected by this change.
Lars
On Wed, Sep 2, 2015 at 12:58 AM, Tran Chau (HISP Vietnam) <
tran.hispvietnam@xxxxxxxxx> wrote:
> Hi Lars,
>
> I start working on it now. I will inform you when I finish.
>
> On Tue, Aug 25, 2015 at 2:31 AM, Lars Helge Øverland <larshelge@xxxxxxxxx>
> wrote:
>
>> Hi Tran, Abyot,
>>
>> I propose that we rename:
>>
>> ProgramInstance.dateOfIncident to incidentDate;
>>
>> and
>>
>> Program.dateOfEnrollmentDescription > enrollmentDateDescription;
>> Program.dateOfIncidentDescription > incidentDateDescription;
>>
>> Yes I know it's problematic to rename variables but it is just really
>> breaking the consistency... We now have:
>>
>> enrollmentDate
>> dueDate
>> executionDate
>> completedDate
>> displayIncidentDate
>>
>> If we can change so that we get:
>>
>> incidentDate
>> enrollmentDateDescription
>> incidentDateDescription
>>
>> we would be consistent. It's better to change this sooner rather than
>> later before the tracker api gets more popular.
>>
>> Tran, could you do this and coordinate with Abyot and Simen so that we do
>> not break web/android clients? I suggest you do it locally, then create and
>> share a patch to give Abyot/Simen a few days to update the clients.
>>
>> What do you think?
>>
>> Lars
>>
>>
>>
>> --
>> Lars Helge Øverland
>> Lead developer, DHIS 2
>> University of Oslo
>> Skype: larshelgeoverland
>> http://www.dhis2.org <https://www.dhis2.org>
>>
>>
>> --
>> Mailing list: https://launchpad.net/~dhis2-devs-core
>> Post to : dhis2-devs-core@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~dhis2-devs-core
>> More help : https://help.launchpad.net/ListHelp
>>
>>
>
--
Lars Helge Øverland
Lead developer, DHIS 2
University of Oslo
Skype: larshelgeoverland
http://www.dhis2.org <https://www.dhis2.org>
References