dhis2-devs-core team mailing list archive

[Bob Jolliffe <bobjolliffe@xxxxxxxxx>]

Hi Lars

Renaming sounds good.  Just a minor clarification request/suggestion below ...

On 25 August 2015 at 10:31, Lars Helge Øverland <larshelge@xxxxxxxxx> wrote:
> Hi Tran, Abyot,
>
> I propose that we rename:
>
> ProgramInstance.dateOfIncident to incidentDate;

+1

>
> and
>
> Program.dateOfEnrollmentDescription > enrollmentDateDescription;
> Program.dateOfIncidentDescription > incidentDateDescription;

If I read this correctly this is a string used as a label for the
field rather than a description.  I'm not really sure this belongs in
the model anyway, but if so maybe enrollmentDateLabel and
incidentDateLabel might be more suitable.

I see there are also similar variables defined in
./dhis-services/dhis-service-mobile/src/main/java/org/hisp/dhis/api/mobile/model/LWUITmodel/Program.java

Whatever you decide, I guess we should change there too (for consistency).

>
> Yes I know it's problematic to rename variables but it is just really
> breaking the consistency... We now have:
>
> enrollmentDate
> dueDate
> executionDate
> completedDate
> displayIncidentDate
>
> If we can change so that we get:
>
> incidentDate
> enrollmentDateDescription
> incidentDateDescription
>
> we would be consistent. It's better to change this sooner rather than later
> before the tracker api gets more popular.
>
> Tran, could you do this and coordinate with Abyot and Simen so that we do
> not break web/android clients? I suggest you do it locally, then create and
> share a patch to give Abyot/Simen a few days to update the clients.
>
> What do you think?
>
> Lars
>
>
>
> --
> Lars Helge Øverland
> Lead developer, DHIS 2
> University of Oslo
> Skype: larshelgeoverland
> http://www.dhis2.org
>
>
> --
> Mailing list: https://launchpad.net/~dhis2-devs-core
> Post to     : dhis2-devs-core@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~dhis2-devs-core
> More help   : https://help.launchpad.net/ListHelp
>