dhis2-devs-core team mailing list archive

[Lars Helge Øverland <larshelge@xxxxxxxxx>]

On Wed, Sep 2, 2015 at 5:32 PM, Bob Jolliffe <bobjolliffe@xxxxxxxxx> wrote:

> Hi Lars
>
> Renaming sounds good.  Just a minor clarification request/suggestion below
> ...
>
> On 25 August 2015 at 10:31, Lars Helge Øverland <larshelge@xxxxxxxxx>
> wrote:
> > Hi Tran, Abyot,
> >
> > I propose that we rename:
> >
> > ProgramInstance.dateOfIncident to incidentDate;
>
> +1
>
> >
> > and
> >
> > Program.dateOfEnrollmentDescription > enrollmentDateDescription;
> > Program.dateOfIncidentDescription > incidentDateDescription;
>
> If I read this correctly this is a string used as a label for the
> field rather than a description.  I'm not really sure this belongs in
> the model anyway, but if so maybe enrollmentDateLabel and
> incidentDateLabel might be more suitable.
>
>
Agreed, label is better. Tran, lets use that since we are changing it
anyway:

Program.dateOfEnrollmentLabel
Program.dateOfIncidentLabel