dhis2-devs-core team mailing list archive

[Abyot Gizaw <abyota@xxxxxxxxx>]

Hi Tran,

Thanks for the fix.

Can you also look into updating the columns in TableAlteror?


---
Thank you,
Abyot.

On Wed, Sep 9, 2015 at 12:05 AM, Tran Chau (HISP Vietnam) <
tran.hispvietnam@xxxxxxxxx> wrote:

> Hi all,
>
> I've finished this one.
>
> I am sending the patch file in this email.
> Please take a look at it.
> Thank you.
>
> ..............................
> Best regards,
> Tran Chau
>
>
> On Wed, Sep 2, 2015 at 12:32 PM, Jan Henrik Øverland <
> janhenrik.overland@xxxxxxxxx> wrote:
>
>>
>>
>> On Wed, Sep 2, 2015 at 6:44 PM, Lars Helge Øverland <larshelge@xxxxxxxxx>
>> wrote:
>>
>>>
>>>
>>> On Wed, Sep 2, 2015 at 5:32 PM, Bob Jolliffe <bobjolliffe@xxxxxxxxx>
>>> wrote:
>>>
>>>> Hi Lars
>>>>
>>>> Renaming sounds good.  Just a minor clarification request/suggestion
>>>> below ...
>>>>
>>>> On 25 August 2015 at 10:31, Lars Helge Øverland <larshelge@xxxxxxxxx>
>>>> wrote:
>>>> > Hi Tran, Abyot,
>>>> >
>>>> > I propose that we rename:
>>>> >
>>>> > ProgramInstance.dateOfIncident to incidentDate;
>>>>
>>>> +1
>>>>
>>>> >
>>>> > and
>>>> >
>>>> > Program.dateOfEnrollmentDescription > enrollmentDateDescription;
>>>> > Program.dateOfIncidentDescription > incidentDateDescription;
>>>>
>>>> If I read this correctly this is a string used as a label for the
>>>> field rather than a description.  I'm not really sure this belongs in
>>>> the model anyway, but if so maybe enrollmentDateLabel and
>>>> incidentDateLabel might be more suitable.
>>>>
>>>>
>>> Agreed, label is better. Tran, lets use that since we are changing it
>>> anyway:
>>>
>>> Program.dateOfEnrollmentLabel
>>> Program.dateOfIncidentLabel
>>>
>>
>> Program.enrollmentDateLabel.... etc
>>
>>
>>>
>>>
>>>
>>>
>>>
>>> --
>>> Mailing list: https://launchpad.net/~dhis2-devs-core
>>> Post to     : dhis2-devs-core@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~dhis2-devs-core
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>>
>>
>
> --
> Mailing list: https://launchpad.net/~dhis2-devs-core
> Post to     : dhis2-devs-core@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~dhis2-devs-core
> More help   : https://help.launchpad.net/ListHelp
>
>