dhis2-devs-core team mailing list archive

["Tran Chau (HISP Vietnam)" <tran.hispvietnam@xxxxxxxxx>]

Hi Lars,

*@Which property is "reportDate" referring to? Is it executionDate? If so
can we rename to excecutionDateLabel ?*

Yes, reportDate is executionDate.
And we don't have any reportDate property in tracker web side.
But there is property called reportDate in ProgramStage class of mobile
side.

I agree that we should change reportDateDescription to excecutionDateLabel as
you mentioned.

............................
Best regards,
Tran Chau



On Fri, Sep 11, 2015 at 9:24 AM, Lars Helge Øverland <larshelge@xxxxxxxxx>
wrote:

> OK but do we have a report date property in the model now?
>
> On Fri, Sep 11, 2015 at 5:32 PM, Abyot Gizaw <abyota@xxxxxxxxx> wrote:
>
>> yes reportDate is executionDate. but long back there was an intention of
>> differentiate executionDate and reportDate - service provision and
>> reporting might not be on the same day.
>>
>>
>> ---
>> Thank you,
>> Abyot.
>>
>> On Fri, Sep 11, 2015 at 3:23 PM, Lars Helge Øverland <larshelge@xxxxxxxxx
>> > wrote:
>>
>>> Thanks Tran. Good work!
>>>
>>> I did another fix to table alteror in 20091.
>>>
>>> There is one more to go:
>>>
>>> ProgramStage.reportDateDescription
>>>
>>> Which property is "reportDate" referring to? Is it executionDate? If so
>>> can we rename to excecutionDateLabel ?
>>>
>>>
>>> Lars
>>>
>>>
>>>
>>>
>>>
>>> On Fri, Sep 11, 2015 at 1:56 PM, Abyot Gizaw <abyota@xxxxxxxxx> wrote:
>>>
>>>> Hi Tran,
>>>>
>>>> Thanks for the patch. I have now applied it and also fixed the problem
>>>> with TableAlteror.
>>>>
>>>> ---
>>>> Thank you,
>>>> Abyot.
>>>>
>>>> On Fri, Sep 11, 2015 at 5:04 AM, Tran Chau (HISP Vietnam) <
>>>> tran.hispvietnam@xxxxxxxxx> wrote:
>>>>
>>>>> Hi Abyot,
>>>>>
>>>>> As you asked me to renaming columns in TableAlteror, I added the SQL
>>>>> for renaming column in *InitTableAlteror *class as follows:
>>>>>
>>>>> executeSql( "ALTER TABLE program rename column
>>>>> dateOfEnrollmentDescription to enrollmentDateLabel;" );
>>>>> executeSql( "ALTER TABLE program rename column
>>>>> dateOfIncidentDescription to incidentDateLabel;" );
>>>>> executeSql( "ALTER TABLE programinstance rename column dateofincident
>>>>> to incidentDate;" );
>>>>>
>>>>> and did test.... But the column names don't rename after starting
>>>>> tomcat.
>>>>> I am not sure why, but it works before ( in DHIS 2.20 )
>>>>>
>>>>> I also tried to put this statement in *TableAlteror*, it doesn't work
>>>>> either.
>>>>>
>>>>> Can you take a look at it ?
>>>>>
>>>>> .....................................
>>>>> Best regards,
>>>>> Tran Chau
>>>>>
>>>>>
>>>>> On Wed, Sep 9, 2015 at 12:57 PM, Tran Chau (HISP Vietnam) <
>>>>> tran.hispvietnam@xxxxxxxxx> wrote:
>>>>>
>>>>>> Oh, Ok.
>>>>>>
>>>>>> On Wed, Sep 9, 2015 at 12:38 AM, Abyot Gizaw <abyota@xxxxxxxxx>
>>>>>> wrote:
>>>>>>
>>>>>>> Hi Tran,
>>>>>>>
>>>>>>> Thanks for the fix.
>>>>>>>
>>>>>>> Can you also look into updating the columns in TableAlteror?
>>>>>>>
>>>>>>>
>>>>>>> ---
>>>>>>> Thank you,
>>>>>>> Abyot.
>>>>>>>
>>>>>>> On Wed, Sep 9, 2015 at 12:05 AM, Tran Chau (HISP Vietnam) <
>>>>>>> tran.hispvietnam@xxxxxxxxx> wrote:
>>>>>>>
>>>>>>>> Hi all,
>>>>>>>>
>>>>>>>> I've finished this one.
>>>>>>>>
>>>>>>>> I am sending the patch file in this email.
>>>>>>>> Please take a look at it.
>>>>>>>> Thank you.
>>>>>>>>
>>>>>>>> ..............................
>>>>>>>> Best regards,
>>>>>>>> Tran Chau
>>>>>>>>
>>>>>>>>
>>>>>>>> On Wed, Sep 2, 2015 at 12:32 PM, Jan Henrik Øverland <
>>>>>>>> janhenrik.overland@xxxxxxxxx> wrote:
>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Wed, Sep 2, 2015 at 6:44 PM, Lars Helge Øverland <
>>>>>>>>> larshelge@xxxxxxxxx> wrote:
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Wed, Sep 2, 2015 at 5:32 PM, Bob Jolliffe <
>>>>>>>>>> bobjolliffe@xxxxxxxxx> wrote:
>>>>>>>>>>
>>>>>>>>>>> Hi Lars
>>>>>>>>>>>
>>>>>>>>>>> Renaming sounds good.  Just a minor clarification
>>>>>>>>>>> request/suggestion below ...
>>>>>>>>>>>
>>>>>>>>>>> On 25 August 2015 at 10:31, Lars Helge Øverland <
>>>>>>>>>>> larshelge@xxxxxxxxx> wrote:
>>>>>>>>>>> > Hi Tran, Abyot,
>>>>>>>>>>> >
>>>>>>>>>>> > I propose that we rename:
>>>>>>>>>>> >
>>>>>>>>>>> > ProgramInstance.dateOfIncident to incidentDate;
>>>>>>>>>>>
>>>>>>>>>>> +1
>>>>>>>>>>>
>>>>>>>>>>> >
>>>>>>>>>>> > and
>>>>>>>>>>> >
>>>>>>>>>>> > Program.dateOfEnrollmentDescription >
>>>>>>>>>>> enrollmentDateDescription;
>>>>>>>>>>> > Program.dateOfIncidentDescription > incidentDateDescription;
>>>>>>>>>>>
>>>>>>>>>>> If I read this correctly this is a string used as a label for the
>>>>>>>>>>> field rather than a description.  I'm not really sure this
>>>>>>>>>>> belongs in
>>>>>>>>>>> the model anyway, but if so maybe enrollmentDateLabel and
>>>>>>>>>>> incidentDateLabel might be more suitable.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>> Agreed, label is better. Tran, lets use that since we are
>>>>>>>>>> changing it anyway:
>>>>>>>>>>
>>>>>>>>>> Program.dateOfEnrollmentLabel
>>>>>>>>>> Program.dateOfIncidentLabel
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Program.enrollmentDateLabel.... etc
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Mailing list: https://launchpad.net/~dhis2-devs-core
>>>>>>>>>> Post to     : dhis2-devs-core@xxxxxxxxxxxxxxxxxxx
>>>>>>>>>> Unsubscribe : https://launchpad.net/~dhis2-devs-core
>>>>>>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Mailing list: https://launchpad.net/~dhis2-devs-core
>>>>>>>> Post to     : dhis2-devs-core@xxxxxxxxxxxxxxxxxxx
>>>>>>>> Unsubscribe : https://launchpad.net/~dhis2-devs-core
>>>>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>> --
>>>> Mailing list: https://launchpad.net/~dhis2-devs-core
>>>> Post to     : dhis2-devs-core@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~dhis2-devs-core
>>>> More help   : https://help.launchpad.net/ListHelp
>>>>
>>>>
>>>
>>>
>>> --
>>> Lars Helge Øverland
>>> Lead developer, DHIS 2
>>> University of Oslo
>>> Skype: larshelgeoverland
>>> http://www.dhis2.org <https://www.dhis2.org>
>>>
>>>
>>
>
>
> --
> Lars Helge Øverland
> Lead developer, DHIS 2
> University of Oslo
> Skype: larshelgeoverland
> http://www.dhis2.org <https://www.dhis2.org>
>
>