← Back to team overview

dhis2-devs-core team mailing list archive

Re: Default view of idObjects in field filter

 

Yes, collections and also id objects.

For the front-end, you shouldn't be using the default view anyways ;)
because name should never be used. Always displayName.

Will make the change early next week unless I hear any complains ;-)

--
Morten

On Fri, Dec 18, 2015 at 1:36 PM, Mark Polak <mark@xxxxxxxxxxxxxxx> wrote:

> Hey,
>
> This would only apply the "sub" items? So say `children` on
> organisationUnits? I guess just the ID is good enough, but for front-end
> side that would mean we'd have to use field filtering for all those cases
> (but perhaps we should have in the first place)
>
> PS: Breaking change for when you're not using field filtering ;)
>
> Regards,
>
> Mark
>
> On Fri, Dec 18, 2015 at 10:31 AM, Morten Olav Hansen <mortenoh@xxxxxxxxx>
> wrote:
>
>> Hi everyone
>>
>> As you probably, if you do something like
>> /api/organisationUnits.json?fields=*
>>
>> All the objects are expanded, and by default the idObjects / collection
>> of idObjects are expanded to include id,code,name,href,created,lastUpdated.
>>
>> This adds a lot of space to default payloads, and I don't think we
>> actually need all this properties.
>>
>> 1) Export use-case: We only want the id, nothing else is important, we
>> just need something to link to
>>
>> 2) App use-case: You just want the id and displayName (you should never
>> use name anymore anyways)
>>
>> I think all our apps probably already are requesting displayName (Jan?),
>> so I don't think a change here would affect anyone.
>>
>> I suggest we change the default to just include the id, and then the user
>> can expand more if he needs to (I'm also open to having id, displayName as
>> default.. although I think in many cases you don't need displayName)
>>
>> --
>> Morten
>>
>> --
>> Mailing list: https://launchpad.net/~dhis2-devs-core
>> Post to     : dhis2-devs-core@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~dhis2-devs-core
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>

References