dhis2-devs-core team mailing list archive

[Lars Helge Øverland <lars@xxxxxxxxx>]

That's good.

Lets get back to this after release..

On Thu, Jun 23, 2016 at 6:36 PM, Morten Olav Hansen <morten@xxxxxxxxx>
wrote:

> Seems it's reverted already, I don't like hiding these issues though. It
> means both dashboard and maintenance apps have field filter issues.
>
> I will keep it enabled locally, and see if i can fix issues with dashboard
> at least.
>
> --
> Morten Olav Hansen
> Senior Engineer, DHIS 2
> University of Oslo
> http://www.dhis2.org
>
> On Thu, Jun 23, 2016 at 11:18 PM, Morten Olav Hansen <morten@xxxxxxxxx>
> wrote:
>
>> Trying to bzr up now, but launchpad seems not very responsive here.. can
>> just replace throw new with continue in line 185 DefaultFilterService
>>
>> This does signal that we have a bunch of bugs though? might be worth the
>> time to investigate?
>>
>> --
>> Morten Olav Hansen
>> Senior Engineer, DHIS 2
>> University of Oslo
>> http://www.dhis2.org
>>
>> On Thu, Jun 23, 2016 at 7:46 PM, Lars Helge Øverland <lars@xxxxxxxxx>
>> wrote:
>>
>>> It is also completely breaking the dashboard. Could we revert..?
>>>
>>> On Thu, Jun 23, 2016 at 2:05 PM, Lars Helge Øverland <lars@xxxxxxxxx>
>>> wrote:
>>>
>>>> Hi,
>>>>
>>>> yes this sounds like too much of a radical change after code freeze,
>>>> and it might affect the entire system which we do not have time to
>>>> re-test..
>>>>
>>>> Is it okay to revert this for now and apply again after release?
>>>>
>>>>
>>>>
>>>> On Thu, Jun 23, 2016 at 1:59 PM, Halvdan Hoem Grelland <
>>>> halvdan@xxxxxxxxx> wrote:
>>>>
>>>>> So... this already breaks the Maintenance app, which we're in the
>>>>> process of testing/bugfixing for release right now. In this particular case
>>>>> a request is made which attempts to include a non-existing field ("level").
>>>>>
>>>>> Though I agree with the change, it doesn't seem like something we want
>>>>> to do post code freeze (which was three days ago), for this exact reason.
>>>>> Maybe revert and re-apply after branching 2.25?
>>>>>
>>>>> On Thu, Jun 23, 2016 at 12:34 PM, Morten Olav Hansen <morten@xxxxxxxxx
>>>>> > wrote:
>>>>>
>>>>>> It's for all, we don't have a way to throw exception only for
>>>>>> specific versions right now. Either way, if you see this exception you have
>>>>>> a bug somewhere.. so it's good for all I think.
>>>>>>
>>>>>> --
>>>>>> Morten Olav Hansen
>>>>>> Senior Engineer, DHIS 2
>>>>>> University of Oslo
>>>>>> http://www.dhis2.org
>>>>>>
>>>>>> On Thu, Jun 23, 2016 at 5:33 PM, Halvdan Hoem Grelland <
>>>>>> halvdan@xxxxxxxxx> wrote:
>>>>>>
>>>>>>> Is this true for all API versions, or only for 24 and up?
>>>>>>>
>>>>>>> On Thu, Jun 23, 2016 at 12:27 PM, Morten Olav Hansen <
>>>>>>> morten@xxxxxxxxx> wrote:
>>>>>>>
>>>>>>>> Hi guys
>>>>>>>>
>>>>>>>> Just a heads up, for a long time now we have just ignored invalid
>>>>>>>> field filters (displayNam not displayName etc), but this is now fixed in
>>>>>>>> latest trunk, this means that invalid filters will not be accepted
>>>>>>>> anymore... probably shouldn't affect any of your apps, but if it does.. it
>>>>>>>> means you are using an invalid field filter.. and probably have a bug in
>>>>>>>> your app somewhere
>>>>>>>>
>>>>>>>> Something like this is now given back
>>>>>>>>
>>>>>>>> [image: Inline image 1]
>>>>>>>>
>>>>>>>> --
>>>>>>>> Morten Olav Hansen
>>>>>>>> Senior Engineer, DHIS 2
>>>>>>>> University of Oslo
>>>>>>>> http://www.dhis2.org
>>>>>>>>
>>>>>>>> --
>>>>>>>> Mailing list: https://launchpad.net/~dhis2-devs-core
>>>>>>>> Post to     : dhis2-devs-core@xxxxxxxxxxxxxxxxxxx
>>>>>>>> Unsubscribe : https://launchpad.net/~dhis2-devs-core
>>>>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Halvdan Hoem Grelland
>>>>>>> Software developer, DHIS 2
>>>>>>> University of Oslo
>>>>>>> http://www.dhis2.org <https://www.dhis2.org/>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Halvdan Hoem Grelland
>>>>> Software developer, DHIS 2
>>>>> University of Oslo
>>>>> http://www.dhis2.org <https://www.dhis2.org/>
>>>>>
>>>>>
>>>>> --
>>>>> Mailing list: https://launchpad.net/~dhis2-devs-core
>>>>> Post to     : dhis2-devs-core@xxxxxxxxxxxxxxxxxxx
>>>>> Unsubscribe : https://launchpad.net/~dhis2-devs-core
>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Lars Helge Øverland
>>>> Lead developer, DHIS 2
>>>> University of Oslo
>>>> Skype: larshelgeoverland
>>>> lars@xxxxxxxxx
>>>> http://www.dhis2.org <https://www.dhis2.org/>
>>>>
>>>>
>>>
>>>
>>> --
>>> Lars Helge Øverland
>>> Lead developer, DHIS 2
>>> University of Oslo
>>> Skype: larshelgeoverland
>>> lars@xxxxxxxxx
>>> http://www.dhis2.org <https://www.dhis2.org/>
>>>
>>>
>>
>


-- 
Lars Helge Øverland
Lead developer, DHIS 2
University of Oslo
Skype: larshelgeoverland
lars@xxxxxxxxx
http://www.dhis2.org <https://www.dhis2.org/>