← Back to team overview

dhis2-devs team mailing list archive

Re: [Branch ~dhis2-devs-core/dhis2/trunk] Rev 193: Easy help implementation. This implementation will bring up popup with content related to particu...

 

> OK. Could you add them? And add some "sample" help properties so that
> people can see how it is done?
> Files are their -  i18n_global_en_GB.properties.
>
>

OK.


>
>> - How are these properties supposed to be loaded in the HelpService
>> object?
>> <p>$i18n.getString( $helpService.getHeader() )</p>
>> <p>$i18n.getString( $helpService.getContent() )</p>
>>
>
> Yes, but that is for displaying the content. I was wondering how the
> properties are loaded from the properties file and into the HelpService /
> HelpContent object...?
> Yes, the only thing we need is to display content, which is responsibility
> of i18n object, which we delegate to do so by passing string property names
> we need. <p>$i18n.getString( $helpService.getHeader() )</p> converts to
> <p>$i18n.getString( 'help.datasetmanmenu' )</p> and finally we get 'Dataset
> Management Menu'.
>

OK so we are reusing the current i18n solution, that's nice.

I made a few minor fixes, see the scm log mail for info..

Nice work.

Lars

References