dhis2-devs team mailing list archive
-
dhis2-devs team
-
Mailing list archive
-
Message #03819
Re: [Bug 430657] Re: Date text field needs validation rule in data entry screen
I dont think it is good to validate through javascript unless it is a
very simple thing and not really data saving related.
In DHIS2, we have this clientside validation without any server
validation. The STQC guys have found only few, but as a pattern we
lack that in our design. Im sure the security testing guys are going 2
find more bugs with validation.
So i suggest unless its a UI thing we should avoid javascript validation.
On 12/22/09, Hieu Dang Duy <hieu.hispvietnam@xxxxxxxxx> wrote:
> Yeas,
>
> I've prepared this function for this one before.
>
> 2009/12/22 Lars Helge Øverland <larshelge@xxxxxxxxx>
>
>> On Tue, Dec 22, 2009 at 11:50 AM, Hieu Dang Duy
>> <hieu.hispvietnam@xxxxxxxxx>wrote:
>>
>> > Hi Lars,
>> >
>> > Can I fix this slight bug ? I've got a normal way to do this without
>> using
>> > validation for text date field in this case of DataEntry ...
>> > That's is disable this text field on mouse out and enable on mouse over.
>> We
>> > do not allow anyone type anything in this field. How do you think about
>> this
>> > ?
>> >
>>
>> Hi Hieu, no we cannot do that, people often enter dates manually, which we
>> should allow.
>>
>> But we could need a general validation of date fields in the system. Can
>> you
>> create a javascript method (maybe using regex?) that does validation on
>> our
>> date format? (which is 'yyyy-MM-dd')
>>
>> Then we can put it in commons.js and use it consistently in the
>> system...
>>
>> Lars
>>
>> --
>> Date text field needs validation rule in data entry screen
>> https://bugs.launchpad.net/bugs/430657
>> You received this bug notification because you are a member of DHIS 2
>> developers, which is subscribed to DHIS.
>>
>> Status in DHIS 2 - District Health Information Software: Confirmed
>>
>> Bug description:
>> DHIS2 --> Services --> Data Entry
>>
>> Here after selecting appropriate organisation unit, data set and period we
>> get data entry screen, here we fill data one by one, after that we press
>> complete button below the data entry form page and we enter some garbage
>> character or special character or numbers in the date text field and it
>> shows it is saving those values. Here we think this "complete" button
>> should
>> have some validation so that it prompts while clicking it if we fill some
>> other characters inside date text field.
>>
>>
>>
>> _______________________________________________
>> Mailing list:
>> https://launchpad.net/~dhis2-devs<https://launchpad.net/%7Edhis2-devs>
>> Post to : dhis2-devs@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe :
>> https://launchpad.net/~dhis2-devs<https://launchpad.net/%7Edhis2-devs>
>> More help : https://help.launchpad.net/ListHelp
>>
>
>
>
> --
> Hieu.HISPVietnam
> Good Health !
>
--
Sent from my mobile device
---
Regards,
Saptarshi PURKAYASTHA
Director R & D, HISP India
Health Information Systems Programme
My Tech Blog: http://sunnytalkstech.blogspot.com
You Live by CHOICE, Not by CHANCE
Follow ups
References