← Back to team overview

dhis2-devs team mailing list archive

Re: [Branch ~dhis2-devs-core/dhis2/trunk] Rev 1335: A few improvements to zero value storage settings.

 

2010/1/25 Jason Pickering <jason.p.pickering@xxxxxxxxx>

> +        return dataElement != null && dataElement.getType().equals(
> DataElement.VALUE_TYPE_INT )
> +            && value != null && ( value.equals( "0" ) ||
> value.startsWith( "0." ) );
>
>
> Sorry for my script-kiddy comments, but I want to be sure I understand
> this part, as zeroes are one of my favourite values.
>
> If a number is an integer, is it ever going to start with 0.?
>
> I would think it would be more efficient to have a regular expression
> to catch all values that might be zero..
>
> 0
> 0.0
> 0.00
> etc
>
>
Tri actually pointed that out to me right now. I have committed a fix which
hopefully gets it right now.

References