dhis2-devs team mailing list archive

[Bob Jolliffe <bobjolliffe@xxxxxxxxx>]

Please do check that this has not broken functionality of dataset
maintenance.  I have checked manually as best I can but might have
missed something.  It seems to me that the designCode is not being
used in the target action so there is no need to pass it (if there was
then it should have been url-encoded first).

Regards
Bob

On 28 April 2010 13:44,  <noreply@xxxxxxxxxxxxx> wrote:
> ------------------------------------------------------------
> revno: 1822
> committer: Bob Jolliffe <bobj@bobj-laptop>
> branch nick: trunk
> timestamp: Wed 2010-04-28 13:41:49 +0100
> message:
>  Removed more ognl errors due to un-encoded string parameters being passed.
> modified:
>  dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/webapp/dhis-web-maintenance-dataset/editCustomValues.vm
>  dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/webapp/dhis-web-maintenance-dataset/selectDataElement.vm
>
>
> --
> lp:dhis2
> https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk
>
> Your team DHIS 2 developers is subscribed to branch lp:dhis2.
> To unsubscribe from this branch go to https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk/+edit-subscription
>
> === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/webapp/dhis-web-maintenance-dataset/editCustomValues.vm'
> --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/webapp/dhis-web-maintenance-dataset/editCustomValues.vm  2010-03-08 14:50:40 +0000
> +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/webapp/dhis-web-maintenance-dataset/editCustomValues.vm  2010-04-28 12:41:49 +0000
> @@ -331,9 +331,7 @@
>   var requestString = 'getSelectedDataElements.action';
>
>   var params = 'dataSetId=' + document.getElementById( 'dataSetIdField' ).value;
> -
> -  params += '&designCode=' + htmlCode;
> -
> +
>   request.sendAsPost( params );
>   request.send( requestString );
>
>
> === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/webapp/dhis-web-maintenance-dataset/selectDataElement.vm'
> --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/webapp/dhis-web-maintenance-dataset/selectDataElement.vm 2009-09-04 10:27:10 +0000
> +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/webapp/dhis-web-maintenance-dataset/selectDataElement.vm 2010-04-28 12:41:49 +0000
> @@ -536,9 +536,7 @@
>   var requestString = 'getSelectedDataElements.action';
>
>   var params = 'dataSetId=' + document.getElementById( 'dataSetIdField' ).value;
> -
> -  params += '&designCode=' + htmlCode;
> -
> +
>   request.sendAsPost( params );
>   request.send( requestString );
>
> @@ -767,4 +765,4 @@
>                </tr>
>                <input type="hidden" name="dataSetIdField" id="dataSetIdField" value="$dataSet.id" />
>  </body>
> -</html>
> \ No newline at end of file
> +</html>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~dhis2-devs
> Post to     : dhis2-devs@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~dhis2-devs
> More help   : https://help.launchpad.net/ListHelp
>
>