← Back to team overview

dhis2-devs team mailing list archive

Re: [Bug 551295] Re: Validation of groupset exclusivity

 

Hi,

I think groups need to be treated the same way as category options; they
should only be created and exist within a group set.

This means that it shouldn't be possible to create groups without first
saying which group set they belong to, and only access the groups from a
group set. This way 1 group cannot exist in more than one group set. If no
group sets exist, then it is not allowed to create any groups either. This
way we will always know what the current group set is.
Similarly when we assign members (orgunits/indicators/data elements) to
groups that has to happen within one group set, and not across all groups as
we have today.

The sequence to follow for the users would then be to create or edit a group
set, then create or modify groups assigned to that group set, and then
add/remove members to those groups, all following the hierarchy of group
set, group, group member.

What do you think?

Ola
-------


2010/5/20 Trí Trần Thanh <tranthanhtri84@xxxxxxxxx>

> Hi lars.
> in the add/update group set windows, i have removed the groups that
> are already member of a group set
> so thats fine
> what needs to be done: when adding/updating a group, we need to check
> each selected dataelement/indicator/orgunit whether it is a member of
> a group in that groups group set
>
>  if ( CollectionUtils.containsAny( selectedDataElement.getGroups(),
> currentGroupSet.getMembers() )
> //then we cannot add
> - What is currentGroupSet ?With new database we don't have any GroupSet ?
> - When add new Group how do you know currentGroupSet to get member ?
>
> ================================
> Tran Thanh Tri
>  HISP Viet Nam
>  Cell phone: +84903670967
>  Website: http://tringuyenvn.com
> ================================
>
>
>
> 2010/5/18 Lars Helge Øverland <larshelge@xxxxxxxxx>:
> >
> >
> > On Tue, May 18, 2010 at 8:57 AM, Thanh Tri Tran <
> tranthanhtri84@xxxxxxxxx>
> > wrote:
> >>
> >> I have solution is: We can create default GroupSet and default Group ?
> >> When create Element, it will belong default Group and default Group will
> >> belong default GroupSet .
> >>
> >
> > I don't think that's necessary... Lets have a chat.
> > Lars
> >
> >>
> >> --
> >> Validation of groupset exclusivity
> >> https://bugs.launchpad.net/bugs/551295
> >> You received this bug notification because you are a member of DHIS 2
> >> developers, which is subscribed to DHIS.
> >>
> >> Status in DHIS 2 - District Health Information Software: Confirmed
> >>
> >> Bug description:
> >> Validation of groupset exclusivity. This applies to dataelement,
> >> indicator, orgunit groupset. Exclusivity means that an element can only
> be a
> >> member of one of the groups in a groupset. This implies that:
> >>
> >> 1) User should not be allowed to assign a group to more than 1 group set
> >> (on both add new and edit existing)
> >> 2) User should not be allowed to assign an element (eg dataelement) to
> >> more than one group in a groupset (on both add new and edit existing)
> >>
> >>
> >>
> >>
> >> _______________________________________________
> >> Mailing list: https://launchpad.net/~dhis2-devs<https://launchpad.net/%7Edhis2-devs>
> >> Post to     : dhis2-devs@xxxxxxxxxxxxxxxxxxx
> >> Unsubscribe : https://launchpad.net/~dhis2-devs<https://launchpad.net/%7Edhis2-devs>
> >> More help   : https://help.launchpad.net/ListHelp
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~dhis2-devs<https://launchpad.net/%7Edhis2-devs>
> > Post to     : dhis2-devs@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~dhis2-devs<https://launchpad.net/%7Edhis2-devs>
> > More help   : https://help.launchpad.net/ListHelp
> >
> >
>
> _______________________________________________
> Mailing list: https://launchpad.net/~dhis2-devs<https://launchpad.net/%7Edhis2-devs>
> Post to     : dhis2-devs@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~dhis2-devs<https://launchpad.net/%7Edhis2-devs>
> More help   : https://help.launchpad.net/ListHelp
>

Follow ups

References