dhis2-devs team mailing list archive

[Thu Tran <585762@xxxxxxxxxxxxxxxxxx>]

** Changed in: dhis2
       Status: New => Fix Committed

-- 
Lack of checking associations between daels and ind, chart
https://bugs.launchpad.net/bugs/585762
You received this bug notification because you are a member of DHIS 2
developers, which is subscribed to DHIS.

Status in DHIS 2 - District Health Information Software: Fix Committed

Bug description:
DHIS2.0.4: when deleting an dael, checking is just for datavalue not yet for the possible associations with ind and chart (through ind) or maybe other elements.

Issues: 
1. for ind: when the dael (which was defined as a part or an element of the indicator: numerator or denumerator) is removed, that ind becomes an invalid ind... but can't be opened for re-edit/change for the elements. And currently, there are 2 reluctant solutions: 1.1. create a new ind to replace the ind 1.2. access to the database for changing the right references for ind-elements (num/denum) field.

2. for chart: this relation (between dael-chart) comes from the medium, the equivalent indicator (ind). When the dael is removed there'd be no datavalue for showing in the graph if running "generate datasource and view chart" but with "view chart based on existing datasource" the graph of that ind/dael still shows. This is weird!!!

Suggestion:
1. Check for dataelement-deletion including further related elements, at least: datavalue, ind, chart, etc.
2. The message/warning for unsucessful-deletion of dael should be more outstanding... not just a message on the right-hand corner and it's easy to be ignored by users.
3. In the case of invalid ind due to missing daels, re-editing the ind is the better solution than creating a new ind or having rights to access to the database for running queries. Currently, re-edit for the invalid elements of ind is blocked with an exception without any suggested solution.
4. For the chart with invalid ind due to missing daels: more info/warning to users that the chart object contains an invalid ind due to... and ect.

Totally, association, check-ups, reliabilities, information and friendliness are should be counted, esp. for these basic element/function