dhis2-devs team mailing list archive

[Bob Jolliffe <bobjolliffe@xxxxxxxxx>]

Hi Tri

On 1 September 2010 15:16, Tri Tran Thanh <tranthanhtri84@xxxxxxxxx> wrote:
> Hi everybody, sorry for javascript bugs. I have to change something in
> common javascript. That why have that bugs. I will commit new code.

No problem.  At least I think this one is fixed now.  Are there any
other functions within commons.js you are planning to rename or move?
If so, then maybe just do a quick check to see if they are being
referred to anywhere.  For example, for this last one I did

grep -r --include=*.js getElementValue .

to search for all references to getElementValue in js files.  Assumes
you have grep of course but I am sure you can do similar things with
other tools.

Cheers
Bob

>
> Thanks
> ================================
> Tran Thanh Tri
>   HISP Viet Nam
>   Cell phone: +84903670967
>
> ================================
>
>
> On 1 September 2010 18:25, Bob Jolliffe <bobjolliffe@xxxxxxxxx> wrote:
>> Done.  There were 215 references to getElementValue and 0 to
>> getElementaValue so I'm guessing this was a typo
>>
>> 2010/9/1 Lars Helge Øverland <larshelge@xxxxxxxxx>:
>>> On Wed, Sep 1, 2010 at 10:21 AM, Bob Jolliffe <bobjolliffe@xxxxxxxxx>
>>> wrote:
>>>
>>>> Looks like this one from Kim might be related:
>>>> http://www.mail-archive.com/dhis2-devs@xxxxxxxxxxxxxxxxxxx/msg06928.html
>>>>
>>>> It looks like when Tri commtted rev2018 he renamed getElementValue
>>>> function in commons.js
>>>>
>>>> > -function getElementValue( parentElement, childElementName )
>>>> > +function getElementaValue( parentElement, childElementName )
>>>>
>>>> I'm trying to figure out if this was deliberate or a stray finger on
>>>> the keyboard ... Tri?  Shall I just put it back?  I can grep first for
>>>> references to getElementaValue I guess.
>>>>
>>>
>>>
>>> Put it back please...
>>>
>>>
>>>>
>>>> Cheers
>>>> Bob
>>>>
>>>> 2010/9/1 Lars Helge Øverland <larshelge@xxxxxxxxx>:
>>>> > Tri, I think this started after your javascript reorganization. Please
>>>> have
>>>> > a look.
>>>> >
>>>> > On Wed, Sep 1, 2010 at 1:17 AM, Bob Jolliffe <bobjolliffe@xxxxxxxxx>
>>>> > wrote:
>>>> >
>>>> >> Public bug reported:
>>>> >>
>>>> >> When you import a file through the import module the status message is
>>>> >> no longer being updated.  It seems the problem might be related to
>>>> >> recent refactoring of ajax libraries - was good as of revision 1920.
>>>> >>
>>>> >> ** Affects: dhis2
>>>> >>     Importance: Undecided
>>>> >>         Status: New
>>>> >>
>>>> >> --
>>>> >> status message not shown during import
>>>> >> https://bugs.launchpad.net/bugs/627714
>>>> >> You received this bug notification because you are a member of DHIS 2
>>>> >> coordinators, which is the registrant for DHIS.
>>>> >>
>>>> >> Status in DHIS 2 - District Health Information Software: New
>>>> >>
>>>> >> Bug description:
>>>> >> When you import a file through the import module the status message is
>>>> no
>>>> >> longer being updated.  It seems the problem might be related to recent
>>>> >> refactoring of ajax libraries - was good as of revision 1920.
>>>> >>
>>>> >>
>>>> >>
>>>> >
>>>> > --
>>>> > status message not shown during import
>>>> > https://bugs.launchpad.net/bugs/627714
>>>> > You received this bug notification because you are a member of DHIS 2
>>>> > coordinators, which is the registrant for DHIS.
>>>> >
>>>> > Status in DHIS 2 - District Health Information Software: New
>>>> >
>>>> > Bug description:
>>>> > When you import a file through the import module the status message is no
>>>> longer being updated.  It seems the problem might be related to recent
>>>> refactoring of ajax libraries - was good as of revision 1920.
>>>> >
>>>> >
>>>> >
>>>>
>>>> --
>>>> status message not shown during import
>>>> https://bugs.launchpad.net/bugs/627714
>>>> You received this bug notification because you are a member of DHIS 2
>>>> coordinators, which is the registrant for DHIS.
>>>>
>>>> Status in DHIS 2 - District Health Information Software: New
>>>>
>>>> Bug description:
>>>> When you import a file through the import module the status message is no
>>>> longer being updated.  It seems the problem might be related to recent
>>>> refactoring of ajax libraries - was good as of revision 1920.
>>>>
>>>>
>>>>
>>>
>>> --
>>> status message not shown during import
>>> https://bugs.launchpad.net/bugs/627714
>>> You received this bug notification because you are a member of DHIS 2
>>> coordinators, which is the registrant for DHIS.
>>>
>>> Status in DHIS 2 - District Health Information Software: New
>>>
>>> Bug description:
>>> When you import a file through the import module the status message is no longer being updated.  It seems the problem might be related to recent refactoring of ajax libraries - was good as of revision 1920.
>>>
>>>
>>>
>>
>> --
>> status message not shown during import
>> https://bugs.launchpad.net/bugs/627714
>> You received this bug notification because you are a member of DHIS 2
>> India Developers, which is subscribed to DHIS.
>>
>> Status in DHIS 2 - District Health Information Software: New
>>
>> Bug description:
>> When you import a file through the import module the status message is no longer being updated.  It seems the problem might be related to recent refactoring of ajax libraries - was good as of revision 1920.
>>
>>
>>
>
> --
> status message not shown during import
> https://bugs.launchpad.net/bugs/627714
> You received this bug notification because you are a member of DHIS 2
> coordinators, which is the registrant for DHIS.
>
> Status in DHIS 2 - District Health Information Software: New
>
> Bug description:
> When you import a file through the import module the status message is no longer being updated.  It seems the problem might be related to recent refactoring of ajax libraries - was good as of revision 1920.
>
>
>

-- 
status message not shown during import
https://bugs.launchpad.net/bugs/627714
You received this bug notification because you are a member of DHIS 2
developers, which is subscribed to DHIS.

Status in DHIS 2 - District Health Information Software: New

Bug description:
When you import a file through the import module the status message is no longer being updated.  It seems the problem might be related to recent refactoring of ajax libraries - was good as of revision 1920.