← Back to team overview

dhis2-devs team mailing list archive

Re: [Branch ~dhis2-devs-core/dhis2/trunk] Rev 2318: DataSet Locking functionality - Improved

 

Hi Hieu,

When clicking on Lock or Unlock Button it is giving "Something went wrong"
message, there is some problem with bean.
OrgUnit tree loading has been improved definitely, but having Child tree and
Selected option is good.

We have to release war file by Friday for Kerala for that we need a stable
version. We have to test the war and then fix all the bugs before Friday, so
we are suggesting not to update this functionality till Friday only.


On Wed, Oct 6, 2010 at 8:51 AM, Hieu Dang Duy <hieu.hispvietnam@xxxxxxxxx>wrote:

> Hi Indian guys,
>
> Could you please tell me *more details on the problem is in India* when
> using this improved one? More details is more clearly.
>

> Anyway, I would like to present to you guys once again about the thing that
> i done.
>
> *REASON:*
>
> First, as before, I'd mailed to the list and say about the confusing things
> when using the old one. So, what i did see in it was that. There are too
> many button that separated to many other meaning (each button is each
> function). For example, "Lock all at level", "Unlock all at level", "Lock
> all at group", "Unlock all at group". And more two selectable options were
> that "Selected" and "Child tree". Say again, each button is each separated
> function. BUT we had already had two main button were that "Lock" and
> "Unlock". So, do you felt to tried of when using them? In my opinion, they
> were too complicated and too difficult to use.
>
> In that mail, I suggested that WE should merge all of them like "Lock all
> at level" and "Lock all at group" into one button only that is "Lock" button
> (already existing) AND similar with the "Unlock" button. On the other hand,
> the orgunit tree has been improved faster and accuracy/persistence NOW. With
> this reason then we could remove "Selected" and "Child tree" too.
>
> *IMPROVED:*
>
> As you can see now its GUI. There are two main methods *
> applyCollectiveDataLock()* AND *removeCollectiveDataLock()*. Their content
> are still not changed, just move them to DataSetLockService to easy in
> maintenance and make the action class more clearly than.
>
> *TESTED:*
>
> I have being tested with many cases like this (with demo_database from
> Sierra)
>
> 1) one period - one dataset - one orgunit ... WORKING PROPERLY
> 2) one period - one dataset - many orgunits...WORKING PROPERLY
> 3) many period - one dataset - one orgunit...WORKING PROPERLY
> 4) many period - one dataset - many orgunits...WORKING PROPERLY
> 5) many period - many dataset - many orgunits...WORKING PROPERLY
>
> That's all !
>
>
> On Tue, Oct 5, 2010 at 7:45 PM, Neeraj Gupta <neeraj.hisp@xxxxxxxxx>wrote:
>
>> Please revert back all the changes as it is not working properly and
>> functionality has been changed.
>>
>> ---
>> Thanks,
>> Neeraj Gupta
>>
>
>
>
> --
> God Helse !
>



-- 
Thanks,
Neeraj Gupta

Follow ups

References