dhis2-devs team mailing list archive

[bharath kumar <chbharathk@xxxxxxxxx>]

In *SystemSettings* we have option to select *Disable data entry when data
set completed; *once we select that option then in the dataentry when we
click Complte button in dataentry it is disabling TextBoxes for dataentry
but not the comments.

So while testing we thought it is a bug as it should disable both TextBox
and Comment, but if we understood wrong then Tran please revert it back.

*
*
2010/10/12 Lars Helge Øverland <larshelge@xxxxxxxxx>

> Hey,
>
> I am not sure if this is the behaviour we want. Marking a dataset as
> complete is a subjective assessment and it doesn't mean that all cells are
> filled, nor that no more data will be entered later. It is not the same as
> the data locking functionality, which will take care of denying further data
> entry. In any case its not a bug, its a change in behaviour which must be
> discussed. Any comments here? I think we should roll this one back..
>
> Lars
>
>
> On Fri, Oct 8, 2010 at 9:35 AM, <noreply@xxxxxxxxxxxxx> wrote:
>
>> ------------------------------------------------------------
>> revno: 2334
>> committer: Tran Chau <tran.hispvietnam@xxxxxxxxx>
>> branch nick: trunk
>> timestamp: Fri 2010-10-08 14:32:01 +0700
>> message:
>>  Fix bug: After clicking Completed button into data entry form, it is
>> still possible to re-enter comments.
>> modified:
>>
>>  dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/form.vm
>>
>>
>> --
>> lp:dhis2
>> https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk<https://code.launchpad.net/%7Edhis2-devs-core/dhis2/trunk>
>>
>> Your team DHIS 2 developers is subscribed to branch lp:dhis2.
>> To unsubscribe from this branch go to
>> https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk/+edit-subscription<https://code.launchpad.net/%7Edhis2-devs-core/dhis2/trunk/+edit-subscription>
>>
>> === modified file
>> 'dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/form.vm'
>> ---
>> dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/form.vm
>>       2010-10-05 06:53:19 +0000
>> +++
>> dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/form.vm
>>       2010-10-08 07:32:01 +0000
>> @@ -211,9 +211,13 @@
>>                        var inputList =
>> entryform.getElementsByTagName('input');
>>                        for(var i=0;i<inputList.length;i++){
>>                                var input = inputList[i];
>> -
>>                                        input.disabled = disabled;
>> -
>> +                       }
>> +
>> +                       var selectList =
>> entryform.getElementsByTagName('select');
>> +                       for(var i=0;i< selectList.length;i++){
>> +                               var select =  selectList[i];
>> +                                       select.disabled = disabled;
>>                        }
>>                }
>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~dhis2-devs<https://launchpad.net/%7Edhis2-devs>
>> Post to     : dhis2-devs@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~dhis2-devs<https://launchpad.net/%7Edhis2-devs>
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~dhis2-devs<https://launchpad.net/%7Edhis2-devs>
> Post to     : dhis2-devs@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~dhis2-devs<https://launchpad.net/%7Edhis2-devs>
> More help   : https://help.launchpad.net/ListHelp
>
>


-- 

Regards,
Bharath Kumar. Ch