dhis2-devs team mailing list archive

[bharath kumar <chbharathk@xxxxxxxxx>]

Disabling inputboxes in the dataenryscreen functionality was there before
(not sure who worked on that),

Tran worked on only disabling *comments*, she can revert that funcationality
back. but still locking input box functionality will be there, so i guess we
should change that as well.

Tran correct me if i am wrong.

2010/10/12 Ola Hodne Titlestad <olati@xxxxxxxxxx>

> Agree with Lars, we should roll back this one.
>
> The complete button was introduced as a subjective way of defining a
> dataset as complete, and we should allow changes and possibly new values
> after this action.
> Subjective or not, complete does not mean final, and it it must be possible
> to make edits and improvements to the data after this point.
>
> Just saw Bharath's email,
> It seems we are combining very different things here, which might be very
> confusing for the users. I understand why you did it from a technical
> perspective (reusing code and buttons on the screen), but it seems it would
> be better to have a separate "lock dataset" button on the data entry form,
> in addition to the "complete" button.
>
> ----------------------------------
> Ola Hodne Titlestad (Mr)
> HISP
> Department of Informatics
> University of Oslo
>
> Mobile: +47 48069736
> Home address: Vetlandsvn. 95B, 0685 Oslo, Norway. Googlemaps link<http://maps.google.com/maps?f=q&source=s_q&hl=en&geocode=&q=Vetlandsvn.+95B,+0685+Oslo,+Norway>
>
>
> 2010/10/12 Lars Helge Øverland <larshelge@xxxxxxxxx>
>
>> Hey,
>>
>> I am not sure if this is the behaviour we want. Marking a dataset as
>> complete is a subjective assessment and it doesn't mean that all cells are
>> filled, nor that no more data will be entered later. It is not the same as
>> the data locking functionality, which will take care of denying further data
>> entry. In any case its not a bug, its a change in behaviour which must be
>> discussed. Any comments here? I think we should roll this one back..
>>
>> Lars
>>
>>
>> On Fri, Oct 8, 2010 at 9:35 AM, <noreply@xxxxxxxxxxxxx> wrote:
>>
>>> ------------------------------------------------------------
>>> revno: 2334
>>> committer: Tran Chau <tran.hispvietnam@xxxxxxxxx>
>>> branch nick: trunk
>>> timestamp: Fri 2010-10-08 14:32:01 +0700
>>> message:
>>>  Fix bug: After clicking Completed button into data entry form, it is
>>> still possible to re-enter comments.
>>> modified:
>>>
>>>  dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/form.vm
>>>
>>>
>>> --
>>> lp:dhis2
>>> https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk<https://code.launchpad.net/%7Edhis2-devs-core/dhis2/trunk>
>>>
>>> Your team DHIS 2 developers is subscribed to branch lp:dhis2.
>>> To unsubscribe from this branch go to
>>> https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk/+edit-subscription<https://code.launchpad.net/%7Edhis2-devs-core/dhis2/trunk/+edit-subscription>
>>>
>>> === modified file
>>> 'dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/form.vm'
>>> ---
>>> dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/form.vm
>>>       2010-10-05 06:53:19 +0000
>>> +++
>>> dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/form.vm
>>>       2010-10-08 07:32:01 +0000
>>> @@ -211,9 +211,13 @@
>>>                        var inputList =
>>> entryform.getElementsByTagName('input');
>>>                        for(var i=0;i<inputList.length;i++){
>>>                                var input = inputList[i];
>>> -
>>>                                        input.disabled = disabled;
>>> -
>>> +                       }
>>> +
>>> +                       var selectList =
>>> entryform.getElementsByTagName('select');
>>> +                       for(var i=0;i< selectList.length;i++){
>>> +                               var select =  selectList[i];
>>> +                                       select.disabled = disabled;
>>>                        }
>>>                }
>>>
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~dhis2-devs<https://launchpad.net/%7Edhis2-devs>
>>> Post to     : dhis2-devs@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~dhis2-devs<https://launchpad.net/%7Edhis2-devs>
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~dhis2-devs<https://launchpad.net/%7Edhis2-devs>
>> Post to     : dhis2-devs@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~dhis2-devs<https://launchpad.net/%7Edhis2-devs>
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~dhis2-devs<https://launchpad.net/%7Edhis2-devs>
> Post to     : dhis2-devs@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~dhis2-devs<https://launchpad.net/%7Edhis2-devs>
> More help   : https://help.launchpad.net/ListHelp
>
>


-- 

Regards,
Bharath Kumar. Ch