dhis2-devs team mailing list archive

[noreply@xxxxxxxxxxxxx]

------------------------------------------------------------
revno: 2601
committer: Lars Helge Overland <larshelge@xxxxxxxxx>
branch nick: dhis2
timestamp: Mon 2011-01-17 17:20:07 +0100
message:
  Removed unused method
modified:
  dhis-2/dhis-api/src/main/java/org/hisp/dhis/reporttable/ReportTableService.java
  dhis-2/dhis-services/dhis-service-reporting/src/main/java/org/hisp/dhis/reporttable/impl/DefaultReportTableService.java
  dhis-2/dhis-services/dhis-service-reporting/src/main/java/org/hisp/dhis/reporttable/jdbc/JDBCReportTableManager.java
  dhis-2/dhis-services/dhis-service-reporting/src/main/java/org/hisp/dhis/reporttable/jdbc/ReportTableManager.java


--
lp:dhis2
https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk

Your team DHIS 2 developers is subscribed to branch lp:dhis2.
To unsubscribe from this branch go to https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk/+edit-subscription

=== modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/reporttable/ReportTableService.java'
--- dhis-2/dhis-api/src/main/java/org/hisp/dhis/reporttable/ReportTableService.java	2011-01-17 16:17:06 +0000
+++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/reporttable/ReportTableService.java	2011-01-17 16:20:07 +0000
@@ -138,14 +138,6 @@
      */
     Grid getReportTableGrid( int id, I18nFormat format, Integer reportingPeriod, Integer organisationUnitId );
     
-    /**
-     * Tests whether the report table has been generated in the database.
-     * 
-     * @param id the ReportTable id.
-     * @return true if the report table has been generated, false it not.
-     */
-    boolean reportTableIsGenerated( int id );
-    
     Collection<ReportTable> getReportTablesBetween( int first, int max );
     
     Collection<ReportTable> getReportTablesBetweenByName( String name, int first, int max );

=== modified file 'dhis-2/dhis-services/dhis-service-reporting/src/main/java/org/hisp/dhis/reporttable/impl/DefaultReportTableService.java'
--- dhis-2/dhis-services/dhis-service-reporting/src/main/java/org/hisp/dhis/reporttable/impl/DefaultReportTableService.java	2011-01-17 16:17:06 +0000
+++ dhis-2/dhis-services/dhis-service-reporting/src/main/java/org/hisp/dhis/reporttable/impl/DefaultReportTableService.java	2011-01-17 16:20:07 +0000
@@ -316,11 +316,6 @@
         return reportTableManager.getReportTableGrid( reportTable );
     }
     
-    public boolean reportTableIsGenerated( int id ) //TODO remove
-    {
-        return reportTableManager.reportTableIsGenerated( getReportTable( id ) );
-    }
-
     @Transactional
     public Collection<ReportTable> getReportTablesBetweenByName( String name, int first, int max )
     {

=== modified file 'dhis-2/dhis-services/dhis-service-reporting/src/main/java/org/hisp/dhis/reporttable/jdbc/JDBCReportTableManager.java'
--- dhis-2/dhis-services/dhis-service-reporting/src/main/java/org/hisp/dhis/reporttable/jdbc/JDBCReportTableManager.java	2011-01-14 18:10:02 +0000
+++ dhis-2/dhis-services/dhis-service-reporting/src/main/java/org/hisp/dhis/reporttable/jdbc/JDBCReportTableManager.java	2011-01-17 16:20:07 +0000
@@ -128,20 +128,6 @@
         }
     }
     
-    public boolean reportTableIsGenerated( ReportTable reportTable )
-    {
-        try
-        {
-            statementManager.getHolder().getStatement().executeQuery( "SELECT count(*) FROM " + reportTable.getExistingTableName() );
-            
-            return true;
-        }
-        catch ( Exception ex )
-        {
-            return false;
-        }
-    }
-    
     public Map<String, Double> getAggregatedValueMap( ReportTable reportTable,
         IdentifiableObject metaObject, DataElementCategoryOptionCombo categoryOptionCombo, Period period, OrganisationUnit unit )
     {

=== modified file 'dhis-2/dhis-services/dhis-service-reporting/src/main/java/org/hisp/dhis/reporttable/jdbc/ReportTableManager.java'
--- dhis-2/dhis-services/dhis-service-reporting/src/main/java/org/hisp/dhis/reporttable/jdbc/ReportTableManager.java	2010-12-26 15:38:45 +0000
+++ dhis-2/dhis-services/dhis-service-reporting/src/main/java/org/hisp/dhis/reporttable/jdbc/ReportTableManager.java	2011-01-17 16:20:07 +0000
@@ -59,14 +59,6 @@
     void removeReportTable( ReportTable reportTable );
     
     /**
-     * Tests whether the report table has been generated in the database.
-     * 
-     * @param reportTable the ReportTable.
-     * @return true if the report table has been generated, false it not.
-     */
-    boolean reportTableIsGenerated( ReportTable reportTable );
-    
-    /**
      * Returns an AggregatedValueMap.
      * 
      * @param reportTable the ReportTable.