dhis2-devs team mailing list archive

["jason.p.pickering" <717761@xxxxxxxxxxxxxxxxxx>]

Hi. Let me offer my perspective here.

1) If the user enters a zero, and the zero is not significant, nothing
should be persisted.
2) If the user enters a non-zero, the value is always persisted.
3) If the user updates an existing value by deleting it from the data
entry screen, the value should be deleted.
4) If the user updates a non-zero value with a zero, and zeros are not
significant, then the value should be effectively deleted. <This is
the case we are dealing with here I think.>
5) If the user updates a non-zero value with a zero and zeros are
significant, then the value should be persisted as a zero.

Lars, I think you are sort of mixing up two things here. I agree that
if the user wants to delete a value, they should just delete it.
However, if they enter a zero, which may actually be the value which
they want to enter, then the system would not persist the value if the
"Zero is significant" setting is not set.

Obviously this in itself is potentially confusing to some users, who
enter zeros, and not knowing if the data element is flagged as "Zero
is significant" or not attempts to check their data entry at a later
stage, only to see that the zero which they entered is actually not
there anymore!

Lastly, I would agree with Tri.  It is not the correct behavior at all
to enter a zero, and then have the old value continue to be persisted.
I think Bjornar's original point is not about deleting values, but
rather entering a zero and the old value continuing to be persisted.
What happens at the time of persistence is a separate issue, to be
determined with the "Zero is significant setting."

My take on it anyway.



On 2/15/11, Tri Tran Thanh <tranthanhtri84@xxxxxxxxx> wrote:
> Hi lars.
> With old way, it will make misunderstanding for user. When they want
> to update existed value with Zero value, in view they see the value
> was changed but it doesn't change in database .
> ================================
> Tran Thanh Tri
>   HISP Viet Nam
>   Cell phone: +84903670967
> ================================
>
>
> On 15 February 2011 02:19, Lars Helge Øverland <larshelge@xxxxxxxxx> wrote:
>> This is not a bug. We do not store 0 values. If u want to remove a value
>> then remove the value and save. Tri, dont commit before discussing these
>> things.
>> On 13 Feb 2011 23:35, "Tri Tran Thanh" <tranthanhtri84@xxxxxxxxx> wrote:
>>> ** Changed in: dhis2
>>> Status: New => Fix Committed
>>>
>>> --
>>> You received this bug notification because you are a member of DHIS 2
>>> coordinators, which is the registrant for DHIS.
>>> https://bugs.launchpad.net/bugs/717761
>>>
>>> Title:
>>> 0 value doesn't delete existing data
>>>
>>> Status in DHIS 2 - District Health Information Software:
>>> Fix Committed
>>>
>>> Bug description:
>>> When entering 0 in a data entry field where a data value already is
>>> entered, the box turns green, indicating that the value is stored. But
>>> when "re-visiting" the form the old value is still there. The data
>>> entry field should be empty!
>>>
>>>
>>
>> --
>> You received this bug notification because you are a bug assignee.
>> https://bugs.launchpad.net/bugs/717761
>>
>> Title:
>>  0 value doesn't delete existing data
>>
>> Status in DHIS 2 - District Health Information Software:
>>  Fix Committed
>>
>> Bug description:
>>  When entering 0 in a data entry field where a data value already is
>>  entered, the box turns green, indicating that the value is stored. But
>>  when "re-visiting" the form the old value is still there. The data
>>  entry field should be empty!
>>
>>
>>
>
> --
> You received this bug notification because you are a member of DHIS 2
> India Developers, which is subscribed to DHIS.
> https://bugs.launchpad.net/bugs/717761
>
> Title:
>   0 value doesn't delete existing data
>
> Status in DHIS 2 - District Health Information Software:
>   Fix Committed
>
> Bug description:
>   When entering 0 in a data entry field where a data value already is
>   entered, the box turns green, indicating that the value is stored. But
>   when "re-visiting" the form the old value is still there. The data
>   entry field should be empty!
>
>
>


-- 
Jason P. Pickering
email: jason.p.pickering@xxxxxxxxx
tel:+260974901293

-- 
You received this bug notification because you are a member of DHIS 2
developers, which is subscribed to DHIS.
https://bugs.launchpad.net/bugs/717761

Title:
  0 value doesn't delete existing data

Status in DHIS 2 - District Health Information Software:
  Fix Committed

Bug description:
  When entering 0 in a data entry field where a data value already is
  entered, the box turns green, indicating that the value is stored. But
  when "re-visiting" the form the old value is still there. The data
  entry field should be empty!