dhis2-devs team mailing list archive

[noreply@xxxxxxxxxxxxx]

------------------------------------------------------------
revno: 9622
committer: Lars Helge Øverland <larshelge@xxxxxxxxx>
branch nick: dhis2
timestamp: Sun 2013-01-27 21:05:28 +0200
message:
  Minor
modified:
  dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/sqlview/ValidateAddUpdateSqlViewAction.java


--
lp:dhis2
https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk

Your team DHIS 2 developers is subscribed to branch lp:dhis2.
To unsubscribe from this branch go to https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk/+edit-subscription

=== modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/sqlview/ValidateAddUpdateSqlViewAction.java'
--- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/sqlview/ValidateAddUpdateSqlViewAction.java	2011-12-26 10:07:59 +0000
+++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/sqlview/ValidateAddUpdateSqlViewAction.java	2013-01-27 19:05:28 +0000
@@ -125,21 +125,21 @@
     {
         message = "";
 
-        if ( (name == null) || (name.trim() == "") )
+        if ( name == null || name.trim().isEmpty() )
         {
             message = i18n.getString( "name_is_null" );
 
             return INPUT;
         }
 
-        if ( mode.equals( ADD ) && (sqlViewService.getSqlView( name ) != null) )
+        if ( mode.equals( ADD ) && sqlViewService.getSqlView( name ) != null )
         {
             message = i18n.getString( "name_in_used" );
 
             return INPUT;
         }
 
-        if ( (sqlquery == null) || (sqlquery.trim() == "") )
+        if ( sqlquery == null || sqlquery.trim().isEmpty() )
         {
             message = i18n.getString( "sqlquery_is_empty" );