dhis2-devs team mailing list archive

[noreply@xxxxxxxxxxxxx]

------------------------------------------------------------
revno: 10665
committer: Lars Helge Øverland <larshelge@xxxxxxxxx>
branch nick: dhis2
timestamp: Mon 2013-04-22 17:12:36 +0200
message:
  Fixed subtle bug related to validation in data entry, if there were no values in the form and you had validation rules intended to check if values existed it would not work as expected.
modified:
  dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/validation/DefaultValidationRuleService.java


--
lp:dhis2
https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk

Your team DHIS 2 developers is subscribed to branch lp:dhis2.
To unsubscribe from this branch go to https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk/+edit-subscription

=== modified file 'dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/validation/DefaultValidationRuleService.java'
--- dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/validation/DefaultValidationRuleService.java	2013-04-04 18:06:19 +0000
+++ dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/validation/DefaultValidationRuleService.java	2013-04-22 15:12:36 +0000
@@ -266,7 +266,7 @@
 
         final Collection<ValidationResult> validationViolations = new HashSet<ValidationResult>();
 
-        if ( currentSize < MAX_VIOLATIONS && !valueMap.isEmpty() )
+        if ( currentSize < MAX_VIOLATIONS )
         {
             Double leftSide = null;
             Double rightSide = null;