← Back to team overview

dhis2-devs team mailing list archive

Re: [Branch ~dhis2-devs-core/dhis2/trunk] Rev 13241: Replace fixed attributes to dynamic attributes (WIP)

 

Hi Tran,

These fixed attributes

1. should be inserted only once - not every time we start  dhis2
2. shouldn't we make at least gender and date of birth mandatory?
3. also, do we need to have some kind of sorting mechanism so that we
control how we display registration form

Abyot.


On Mon, Dec 16, 2013 at 5:47 AM, <noreply@xxxxxxxxxxxxx> wrote:

> ------------------------------------------------------------
> revno: 13241
> committer: Tran Chau <tran.hispvietnam@xxxxxxxxx>
> branch nick: dhis2
> timestamp: Mon 2013-12-16 11:45:10 +0700
> message:
>   Replace fixed attributes to dynamic attributes (WIP)
> modified:
>
> dhis-2/dhis-services/dhis-service-patient/src/main/java/org/hisp/dhis/patient/startup/TableAlteror.java
>
>
> --
> lp:dhis2
> https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk
>
> Your team DHIS 2 developers is subscribed to branch lp:dhis2.
> To unsubscribe from this branch go to
> https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk/+edit-subscription
>
> === modified file
> 'dhis-2/dhis-services/dhis-service-patient/src/main/java/org/hisp/dhis/patient/startup/TableAlteror.java'
> ---
> dhis-2/dhis-services/dhis-service-patient/src/main/java/org/hisp/dhis/patient/startup/TableAlteror.java
>     2013-12-16 04:27:26 +0000
> +++
> dhis-2/dhis-services/dhis-service-patient/src/main/java/org/hisp/dhis/patient/startup/TableAlteror.java
>     2013-12-16 04:45:10 +0000
> @@ -611,12 +611,12 @@
>              + max + ".age]";
>          updateFixedAttributeInCaseAggregate( source, target );
>
> -        // executeSql( "ALTER TABLE patient DROP COLUMN deathDate" );
> -        // executeSql( "ALTER TABLE patient DROP COLUMN registrationDate"
> );
> -        // executeSql( "ALTER TABLE patient DROP COLUMN isDead" );
> -        // executeSql( "ALTER TABLE patient DROP COLUMN underAge" );
> -        // executeSql( "ALTER TABLE patient DROP COLUMN dobType" );
> -        // executeSql( "ALTER TABLE patient DROP COLUMN birthdate" );
> +         executeSql( "ALTER TABLE patient DROP COLUMN deathDate" );
> +         executeSql( "ALTER TABLE patient DROP COLUMN registrationDate" );
> +         executeSql( "ALTER TABLE patient DROP COLUMN isDead" );
> +         executeSql( "ALTER TABLE patient DROP COLUMN underAge" );
> +         executeSql( "ALTER TABLE patient DROP COLUMN dobType" );
> +         executeSql( "ALTER TABLE patient DROP COLUMN birthdate" );
>      }
>
>      private void updateFixedAttributeInCaseAggregate( String source,
> String target )
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~dhis2-devs
> Post to     : dhis2-devs@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~dhis2-devs
> More help   : https://help.launchpad.net/ListHelp
>
>

Follow ups

References