← Back to team overview

dhis2-devs team mailing list archive

Re: Limit characters in Comment

 

Hi Channara,

the max is actually 255 characters, backed by a "varchar" column in the
database. I'm sorry but we don't plan to change it to a "text" type column
anytime soon - reason is just that most comments are pretty short and
"text" requires more storage space on disk.

Now that said you are of course free to change the column type to text
directly in your database, and then apply the patch copied below this email
to remove the validation.

regards,

Lars

-----


=== modified file
'dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/javascript/history.js'
---
dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/javascript/history.js
2014-02-27
04:15:35 +0000
+++
dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/javascript/history.js
2014-04-09
08:01:57 +0000
@@ -5,14 +5,6 @@

     var commentValue = $( '#commentTextArea' ).val();

-    if ( commentValue.length > 360 )
-    {
-        markComment( COLOR_YELLOW );
-        window.alert(i18n_value_too_long + " for comment field");
-
-        return;
-    }
-
     var commentSaver = new CommentSaver( currentDataElementId,
currentOptionComboId, commentValue );

     commentSaver.save();





















On Wed, Apr 9, 2014 at 6:55 AM, channara rin <rin.channara@xxxxxxxxx> wrote:

> Dear All,
> I found that, in the Comment in data value in dataset is
> limit character around 360characters.
> Can we extend to unlimited characters for comments?
>
>
> Thank you
> CHANNARA
>
> _______________________________________________
> Mailing list: https://launchpad.net/~dhis2-devs
> Post to     : dhis2-devs@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~dhis2-devs
> More help   : https://help.launchpad.net/ListHelp
>
>

Follow ups

References