← Back to team overview

dhis2-devs team mailing list archive

[Branch ~dhis2-devs-core/dhis2/trunk] Rev 16583: HibernateOptionStore, removed name.toLowerCase, inconsitent and nullpointer vulnerable

 

------------------------------------------------------------
revno: 16583
committer: Lars Helge Overland <larshelge@xxxxxxxxx>
branch nick: dhis2
timestamp: Fri 2014-08-29 17:54:19 +0200
message:
  HibernateOptionStore, removed name.toLowerCase, inconsitent and nullpointer vulnerable
modified:
  dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/option/hibernate/HibernateOptionStore.java


--
lp:dhis2
https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk

Your team DHIS 2 developers is subscribed to branch lp:dhis2.
To unsubscribe from this branch go to https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk/+edit-subscription
=== modified file 'dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/option/hibernate/HibernateOptionStore.java'
--- dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/option/hibernate/HibernateOptionStore.java	2014-08-29 15:16:13 +0000
+++ dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/option/hibernate/HibernateOptionStore.java	2014-08-29 15:54:19 +0000
@@ -82,7 +82,7 @@
 
         Query query = getQuery( hql );
         query.setEntity( "optionSet", optionSet );
-        query.setString( "name", name.toLowerCase() );
+        query.setString( "name", name );
 
         return (Option) query.uniqueResult();
     }