dhis2-devs team mailing list archive
-
dhis2-devs team
-
Mailing list archive
-
Message #34928
[Branch ~dhis2-devs-core/dhis2/trunk] Rev 17917: make sure pageSize and pageCount have positive integer value
------------------------------------------------------------
revno: 17917
committer: Abyot Asalefew Gizaw <abyota@xxxxxxxxx>
branch nick: dhis2
timestamp: Thu 2015-01-08 17:39:10 +0100
message:
make sure pageSize and pageCount have positive integer value
modified:
dhis-2/dhis-web/dhis-web-apps/src/main/webapp/dhis-web-event-capture/scripts/services.js
dhis-2/dhis-web/dhis-web-apps/src/main/webapp/dhis-web-tracker-capture/scripts/services.js
dhis-2/dhis-web/dhis-web-commons-resources/src/main/webapp/dhis-web-commons/paging/serverside-pagination.html
--
lp:dhis2
https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk
Your team DHIS 2 developers is subscribed to branch lp:dhis2.
To unsubscribe from this branch go to https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk/+edit-subscription
=== modified file 'dhis-2/dhis-web/dhis-web-apps/src/main/webapp/dhis-web-event-capture/scripts/services.js'
--- dhis-2/dhis-web/dhis-web-apps/src/main/webapp/dhis-web-event-capture/scripts/services.js 2014-12-15 14:00:36 +0000
+++ dhis-2/dhis-web/dhis-web-apps/src/main/webapp/dhis-web-event-capture/scripts/services.js 2015-01-08 16:39:10 +0000
@@ -198,6 +198,8 @@
getByStage: function(orgUnit, programStage, pager){
var pgSize = pager ? pager.pageSize : 50;
var pg = pager ? pager.page : 1;
+ pgSize = pgSize > 1 ? pgSize : 1;
+ pg = pg > 1 ? pg : 1;
var url = '../api/events.json?' + 'orgUnit=' + orgUnit + '&programStage=' + programStage + '&pageSize=' + pgSize + '&page=' + pg;
var promise = $http.get( url ).then(function(response){
@@ -311,4 +313,4 @@
return e;
}
};
-});
+});
\ No newline at end of file
=== modified file 'dhis-2/dhis-web/dhis-web-apps/src/main/webapp/dhis-web-tracker-capture/scripts/services.js'
--- dhis-2/dhis-web/dhis-web-apps/src/main/webapp/dhis-web-tracker-capture/scripts/services.js 2015-01-05 15:31:59 +0000
+++ dhis-2/dhis-web/dhis-web-apps/src/main/webapp/dhis-web-tracker-capture/scripts/services.js 2015-01-08 16:39:10 +0000
@@ -468,6 +468,8 @@
if(paging){
var pgSize = pager ? pager.pageSize : 50;
var pg = pager ? pager.page : 1;
+ pgSize = pgSize > 1 ? pgSize : 1;
+ pg = pg > 1 ? pg : 1;
url = url + '&pageSize=' + pgSize + '&page=' + pg;
}
else{
@@ -795,6 +797,8 @@
getEventReport: function(orgUnit, ouMode, program, startDate, endDate, programStatus, eventStatus, pager){
var pgSize = pager ? pager.pageSize : 50;
var pg = pager ? pager.page : 1;
+ pgSize = pgSize > 1 ? pgSize : 1;
+ pg = pg > 1 ? pg : 1;
var url = '../api/events/eventRows.json?' + 'orgUnit=' + orgUnit + '&ouMode='+ ouMode + '&program=' + program + '&programStatus=' + programStatus + '&eventStatus='+ eventStatus + '&pageSize=' + pgSize + '&page=' + pg;
if(startDate && endDate){
url = url + '&startDate=' + startDate + '&endDate=' + endDate ;
=== modified file 'dhis-2/dhis-web/dhis-web-commons-resources/src/main/webapp/dhis-web-commons/paging/serverside-pagination.html'
--- dhis-2/dhis-web/dhis-web-commons-resources/src/main/webapp/dhis-web-commons/paging/serverside-pagination.html 2014-12-08 15:56:07 +0000
+++ dhis-2/dhis-web/dhis-web-commons-resources/src/main/webapp/dhis-web-commons/paging/serverside-pagination.html 2015-01-08 16:39:10 +0000
@@ -5,10 +5,10 @@
{{'total_number_of_pages'| translate}}: {{pager.pageCount}}
</td>
<td>
- <span>{{'rows_per_page'| translate}}:</span> <input type="text" style="width:50px;" ng-model="pager.pageSize" ng-blur="resetPageSize()">
+ <span>{{'rows_per_page'| translate}}:</span> <input type="text" min="1" style="width:50px;" ng-model="pager.pageSize" ng-blur="resetPageSize()">
</td>
<td>
- <span>{{'jump_to_page'| translate}}:</span> <input type="text" style="width:50px;" ng-model="pager.page" ng-blur="jumpToPage()">
+ <span>{{'jump_to_page'| translate}}:</span> <input type="text" min="1" style="width:50px;" ng-model="pager.page" ng-blur="jumpToPage()">
</td>
</tr>
<tr>