← Back to team overview

dhis2-devs team mailing list archive

Re: [Bug 1464211] [NEW] validation not relevant

 

Hi all,

we have experienced the same problem with permissions in data-approval
screen. We have two users: one has all the authorities except ALL; the
other has all the authorities, including ALL. Both users are assigned
to the same data capture and data analysis org units, both are
assigned all datasets, and both should be able to approve data. But
what actually happens is that only user with ALL authority can see the
"Ready for approval" message.

Browsing the code, we got the part that seems to control the behaviour
of that message (line 404 in
http://bazaar.launchpad.net/~dhis2-devs-core/dhis2/trunk/view/head:/dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/dataapproval/hibernate/HibernateDataApprovalStore.java).
In particular, in line 424 there is a condition that is skipped for
SuperUsers and that evaluates to false for non-SuperUsers.

The condition seems to evaluate if the user has permission to read the
dataelementcategoryoption associated to the dataset (in our case,
"default"). As "default" publicaccess is "------", the evaluation
returns false. We tried changing the "default" publicaccess value from
"------" to "rw----", and then non-SuperUser user was able to see the
"Ready for approval" message and approve the dataset.

Hope this helps in finding the solution.

Thanks!

On 11 June 2015 at 12:39, lionel ruberintwari <ruberlio@xxxxxxxxx> wrote:
> Public bug reported:
>
> using DHIS2 2.18 version, users with validation data accounts are
> experiencing error saying "validation not relevant" but users with
> "superuser account" can proceed with validation data.
>
> ** Affects: dhis2
>      Importance: Undecided
>          Status: New
>
> --
> You received this bug notification because you are a member of DHIS 2
> developers, which is subscribed to DHIS.
> https://bugs.launchpad.net/bugs/1464211
>
> Title:
>   validation not relevant
>
> Status in DHIS 2:
>   New
>
> Bug description:
>   using DHIS2 2.18 version, users with validation data accounts are
>   experiencing error saying "validation not relevant" but users with
>   "superuser account" can proceed with validation data.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/dhis2/+bug/1464211/+subscriptions
>
> _______________________________________________
> Mailing list: https://launchpad.net/~dhis2-devs
> Post to     : dhis2-devs@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~dhis2-devs
> More help   : https://help.launchpad.net/ListHelp


References