dhis2-devs team mailing list archive

[noreply@xxxxxxxxxxxxx]

------------------------------------------------------------
revno: 20494
committer: Lars Helge Overland <larshelge@xxxxxxxxx>
branch nick: dhis2
timestamp: Sat 2015-10-03 13:21:44 +0200
message:
  Unused code
modified:
  dhis-2/dhis-api/src/main/java/org/hisp/dhis/completeness/DataSetCompletenessStore.java
  dhis-2/dhis-services/dhis-service-reporting/src/main/java/org/hisp/dhis/completeness/jdbc/JDBCDataSetCompletenessStore.java


--
lp:dhis2
https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk

Your team DHIS 2 developers is subscribed to branch lp:dhis2.
To unsubscribe from this branch go to https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk/+edit-subscription

=== modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/completeness/DataSetCompletenessStore.java'
--- dhis-2/dhis-api/src/main/java/org/hisp/dhis/completeness/DataSetCompletenessStore.java	2015-10-03 11:09:07 +0000
+++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/completeness/DataSetCompletenessStore.java	2015-10-03 11:21:44 +0000
@@ -49,23 +49,4 @@
     Integer getCompulsoryDataElementRegistrations( DataSet dataSet, Collection<Integer> children, Collection<Integer> periods, int completenessOffset );
 
     List<DataSet> getDataSetsWithRegistrations( Collection<DataSet> dataSets );
-
-    /**
-     * Gets the percentage value for the datasetcompleteness with the given parameters.
-     *
-     * @param dataSetId the DataSet identifier.
-     * @param periodId  the Period identifier.
-     * @param sourceId  the Source identifier.
-     * @return the percentage value for the datasetcompleteness result with the given parameters.
-     */
-    Double getPercentage( int dataSetId, int periodId, int sourceId );
-
-    /**
-     * Deletes the datasetcompleteness entries with the given parameters.
-     *
-     * @param dataSetIds the DataSet identifiers.
-     * @param periodIds  the Period identifiers.
-     * @param sourceIds  the Source identifiers.
-     */
-    void deleteDataSetCompleteness( Collection<Integer> dataSetIds, Collection<Integer> periodIds, Collection<Integer> sourceIds );
 }

=== modified file 'dhis-2/dhis-services/dhis-service-reporting/src/main/java/org/hisp/dhis/completeness/jdbc/JDBCDataSetCompletenessStore.java'
--- dhis-2/dhis-services/dhis-service-reporting/src/main/java/org/hisp/dhis/completeness/jdbc/JDBCDataSetCompletenessStore.java	2015-10-03 11:09:07 +0000
+++ dhis-2/dhis-services/dhis-service-reporting/src/main/java/org/hisp/dhis/completeness/jdbc/JDBCDataSetCompletenessStore.java	2015-10-03 11:21:44 +0000
@@ -167,38 +167,4 @@
         
         return selection;
     }
-
-    // -------------------------------------------------------------------------
-    // Aggregated data set completeness methods
-    // -------------------------------------------------------------------------
-
-    @Override
-    public Double getPercentage( int dataSetId, int periodId, int organisationUnitId )
-    {
-        final String sql =
-            "SELECT value " +
-            "FROM aggregateddatasetcompleteness " +
-            "WHERE datasetid = " + dataSetId + " " +
-            "AND periodid = " + periodId + " " +
-            "AND organisationunitid = " + organisationUnitId;
-        
-        return statementManager.getHolder().queryForDouble( sql );
-    }
-    
-    @Override
-    public void deleteDataSetCompleteness( Collection<Integer> dataSetIds, Collection<Integer> periodIds, Collection<Integer> organisationUnitIds )
-    {
-        if ( dataSetIds == null || dataSetIds.isEmpty() || periodIds == null || periodIds.isEmpty() || organisationUnitIds == null || organisationUnitIds.isEmpty() )
-        {
-            return;
-        }
-        
-        final String sql = 
-            "DELETE FROM aggregateddatasetcompleteness " +
-            "WHERE datasetid IN ( " + getCommaDelimitedString( dataSetIds ) + " ) " +
-            "AND periodid IN ( " + getCommaDelimitedString( periodIds ) + " ) " +
-            "AND organisationunitid IN ( " + getCommaDelimitedString( organisationUnitIds ) + " )";
-        
-        statementManager.getHolder().executeUpdate( sql );
-    }
 }