dhis2-devs team mailing list archive

[noreply@xxxxxxxxxxxxx]

------------------------------------------------------------
revno: 20763
committer: Lars Helge Overland <larshelge@xxxxxxxxx>
branch nick: dhis2
timestamp: Mon 2015-10-19 13:29:14 +0200
message:
  Approval, reduced log level
modified:
  dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/dataapproval/hibernate/HibernateDataApprovalStore.java


--
lp:dhis2
https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk

Your team DHIS 2 developers is subscribed to branch lp:dhis2.
To unsubscribe from this branch go to https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk/+edit-subscription

=== modified file 'dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/dataapproval/hibernate/HibernateDataApprovalStore.java'
--- dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/dataapproval/hibernate/HibernateDataApprovalStore.java	2015-10-06 18:24:42 +0000
+++ dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/dataapproval/hibernate/HibernateDataApprovalStore.java	2015-10-19 11:29:14 +0000
@@ -189,6 +189,7 @@
         final User user = currentUserService.getCurrentUser();
 
         Set<DataSet> validDataSets = new HashSet<>();
+        
         for ( DataSet set : dataSets )
         {
             if ( set.isApproveData() )
@@ -199,7 +200,7 @@
 
         if ( CollectionUtils.isEmpty( validDataSets ) )
         {
-            log.warn( " No valid data sets specified for getting approvals, period " + period.getName()
+            log.debug( " No valid data sets specified for getting approvals, period " + period.getName()
                 + " user " + ( user == null ? "(null)" : user.getUsername() ) );
 
             return new ArrayList<>();
@@ -260,7 +261,7 @@
 
             if ( catComboIds.isEmpty() )
             {
-                log.warn( "No dataset categorycombos to check for approval, user " + ( user == null ? "(null)" : user.getUsername() ) + " datasetIds " + dataSetIds );
+                log.info( "No dataset categorycombos to check for approval, user " + ( user == null ? "(null)" : user.getUsername() ) + " datasetIds " + dataSetIds );
 
                 return new ArrayList<>();
             }
@@ -272,7 +273,7 @@
 
         if ( CollectionUtils.isEmpty( approvalLevels ) )
         {
-            log.warn( " No approval levels configured." );
+            log.info( "No approval levels configured" );
 
             return new ArrayList<>(); // Unapprovable.
         }