dhis2-devs team mailing list archive

[Calle Hedberg <calle.hedberg@xxxxxxxxx>]

Public bug reported:

If there are one or more UIDs referenced in a custom data entry form,
those errors will be intercepted and displayed to the user when trying
to open that form.

The same errors caused a total crash when running Data Validation,
though, yielding only the following non-helpful tomcat log thread below.

The Data Validation process should either provide the user with an
actionable error message as is done when opening the data entry form, or
else it should at least continue Validation Processing.

The bug has been verified in the DHIS2 Demo:
1. Data Validation runs fine.
2. Open the custom data entry form for e.g. the Child Health Data Set, switch to source code and change some of the Data Element UIDs (the changed UID obviously do not exist in the dataelement table).
3. Data Validation no longer runs.

TOMCAT LOG:
* ERROR 2016-04-07 11:16:26,155 Unexpected error occurred in scheduled task. (TaskUtils.java [taskScheduler-1])
java.lang.NullPointerException
        at org.hisp.dhis.dataintegrity.DefaultDataIntegrityService.getCategoryOptionCombosNotInDataElementCategoryCombo(DefaultDataIntegrityService.java:326)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
        at java.lang.reflect.Method.invoke(Unknown Source)
        at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:190)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:157)
        at org.springframework.transaction.interceptor.TransactionInterceptor$1.proceedWithInvocation(TransactionInterceptor.java:99)
        at org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:281)
        at org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:96)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)
        at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:207)
        at com.sun.proxy.$Proxy105.getCategoryOptionCombosNotInDataElementCategoryCombo(Unknown Source)
        at org.hisp.dhis.dataintegrity.tasks.DataIntegrityTask.run(DataIntegrityTask.java:96)
        at org.springframework.scheduling.support.DelegatingErrorHandlingRunnable.run(DelegatingErrorHandlingRunnable.java:54)
        at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
        at java.util.concurrent.FutureTask.run(Unknown Source)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(Unknown Source)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown Source)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
        at java.lang.Thread.run(Unknown Source)

After this the log hangs - there is no "caused by" etc that usually
provides a better guide to the source of the problem.

** Affects: dhis2
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of DHIS 2
developers, which is subscribed to DHIS.
https://bugs.launchpad.net/bugs/1569817

Title:
  UID error in custom data entry form crashes data validation

Status in DHIS:
  New

Bug description:
  If there are one or more UIDs referenced in a custom data entry form,
  those errors will be intercepted and displayed to the user when trying
  to open that form.

  The same errors caused a total crash when running Data Validation,
  though, yielding only the following non-helpful tomcat log thread
  below.

  The Data Validation process should either provide the user with an
  actionable error message as is done when opening the data entry form,
  or else it should at least continue Validation Processing.

  The bug has been verified in the DHIS2 Demo:
  1. Data Validation runs fine.
  2. Open the custom data entry form for e.g. the Child Health Data Set, switch to source code and change some of the Data Element UIDs (the changed UID obviously do not exist in the dataelement table).
  3. Data Validation no longer runs.

  TOMCAT LOG:
  * ERROR 2016-04-07 11:16:26,155 Unexpected error occurred in scheduled task. (TaskUtils.java [taskScheduler-1])
  java.lang.NullPointerException
          at org.hisp.dhis.dataintegrity.DefaultDataIntegrityService.getCategoryOptionCombosNotInDataElementCategoryCombo(DefaultDataIntegrityService.java:326)
          at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
          at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
          at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
          at java.lang.reflect.Method.invoke(Unknown Source)
          at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
          at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:190)
          at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:157)
          at org.springframework.transaction.interceptor.TransactionInterceptor$1.proceedWithInvocation(TransactionInterceptor.java:99)
          at org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:281)
          at org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:96)
          at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)
          at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:207)
          at com.sun.proxy.$Proxy105.getCategoryOptionCombosNotInDataElementCategoryCombo(Unknown Source)
          at org.hisp.dhis.dataintegrity.tasks.DataIntegrityTask.run(DataIntegrityTask.java:96)
          at org.springframework.scheduling.support.DelegatingErrorHandlingRunnable.run(DelegatingErrorHandlingRunnable.java:54)
          at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
          at java.util.concurrent.FutureTask.run(Unknown Source)
          at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(Unknown Source)
          at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown Source)
          at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
          at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
          at java.lang.Thread.run(Unknown Source)

  After this the log hangs - there is no "caused by" etc that usually
  provides a better guide to the source of the problem.

To manage notifications about this bug go to:
https://bugs.launchpad.net/dhis2/+bug/1569817/+subscriptions