← Back to team overview

dhis2-devs team mailing list archive

Re: [Bug 1567905] [NEW] Tracker Capture - Attribute Yes/No display error

 

Abyot,

We suddenly realised that we might be talking past each other: we have the
display problem when using yes/no for ATTRIBUTES, not for data elements.
yes/no data elements display OK.

Regards
Calle

On 16 April 2016 at 13:14, Calle Hedberg <calle.hedberg@xxxxxxxxx> wrote:

> Abyot,
>
> Weird - because we are still getting the erroneous yes/no display.
>
> OK - we decided this morning to replace the standard form for this data
> set with a custom form. If the problem persist, I will do a dump of the
> database (it is small, only some sample test data) and email to you so that
> you can install on your local machine and identify the root cause of this.
> If the problem disappear, well then it's resolved :-)
>
> Regards
> Calle
>
> On 15 April 2016 at 12:11, Abyot Asalefew Gizaw <abyot@xxxxxxxxx> wrote:
>
>> Hi Calle,
>>
>> What exactly is the problem? In 2.22 (demo version) we have the following:
>>
>> [image: Inline image 1]
>>
>> --
>> Abyot A. Gizaw.
>> Senior Engineer, DHIS2
>> University of Oslo
>> http://www.dhis2.org
>>
>> On Fri, Apr 15, 2016 at 11:42 AM, Calle Hedberg <calle.hedberg@xxxxxxxxx>
>> wrote:
>>
>>> Abyot,
>>>
>>> we have the radio button yes/no display problem on 2.22, build 21974
>>>
>>> Regards
>>> Calle
>>>
>>> On 11 April 2016 at 16:07, Abyot Asalefew Gizaw <abyot@xxxxxxxxx> wrote:
>>>
>>>> Hi Calle,
>>>>
>>>>
>>>> Just now checked this bug, below is what we have:
>>>>
>>>> 2.21 (Rev. 21602). I remembered that we have changed it to drop-down.
>>>> Strange that you still have the inline style - can you check the revision
>>>> number?
>>>>
>>>> [image: Inline image 1]
>>>> For 2.22 and trunk
>>>>
>>>> [image: Inline image 2]
>>>>
>>>>
>>>> --
>>>> Abyot A. Gizaw.
>>>> Senior Engineer, DHIS2
>>>> University of Oslo
>>>> http://www.dhis2.org
>>>>
>>>> On Fri, Apr 8, 2016 at 3:31 PM, Calle Hedberg <calle.hedberg@xxxxxxxxx>
>>>> wrote:
>>>>
>>>>> Abyot,
>>>>>
>>>>> That is a generic question:
>>>>>
>>>>> In general, I would say that a null value should not be accepted for a
>>>>> yes/no field - if you want to store "unknown", then create a data element
>>>>> with those three options (Yes, No, Unknown).
>>>>>
>>>>> In practice, you can deal with it in two ways:
>>>>> - use a default choice (preferably user-specified, otherwise typically
>>>>> No)
>>>>> or
>>>>> - not enabling the submit button if none of the radio buttons are
>>>>> ticked (i.e. user cannot save the form without completing the choice
>>>>> between yes and no).
>>>>>
>>>>> That said, it might be TECHNICALLY feasible to simply leave the value
>>>>> blank - it depends on what the underlying data type in e.g. PostgreSQL will
>>>>> allow. For instance, if you ACTUALLY store a yes/no data type using an
>>>>> integer data type that has been restricted to 0 or 1, then you can
>>>>> obviously store a NULL value. So it depends on the data typing.
>>>>>
>>>>> BUT, as I said above: fundamentally you use Yes/No for a phenomena
>>>>> that is either Yes or No - and while the knowledge to determine which of
>>>>> them is correct might be unknown (or it is not clear), you would/should
>>>>> usually just determine a default value. In the case of "Driver's License",
>>>>> I would use a default value of 0 (No).  For a data element like "All limbs
>>>>> present and accounted for" I would us a default value of 1 - unless it is a
>>>>> database only comprising amputees! :-)
>>>>>
>>>>> Regards
>>>>> Calle
>>>>>
>>>>> On 8 April 2016 at 14:20, Abyot Asalefew Gizaw <abyot@xxxxxxxxx>
>>>>> wrote:
>>>>>
>>>>>> Hi Calle,
>>>>>>
>>>>>> Thank you for reporting.
>>>>>>
>>>>>> I will fix for the display. We have three buttons because it allows
>>>>>> to reset a value. What will happen if the question of "Driver's License" is
>>>>>> not answered (neither yes nor no) ?
>>>>>>
>>>>>> --
>>>>>> Abyot A. Gizaw.
>>>>>> Senior Engineer, DHIS2
>>>>>> University of Oslo
>>>>>> http://www.dhis2.org
>>>>>>
>>>>>> On Fri, Apr 8, 2016 at 1:56 PM, Calle Hedberg <
>>>>>> calle.hedberg@xxxxxxxxx> wrote:
>>>>>>
>>>>>>> Public bug reported:
>>>>>>>
>>>>>>> Using the latest version of 2.21 (8 April 2016), we have defined one
>>>>>>> attribute called "Driver's License" as have data type Yes/No.
>>>>>>>
>>>>>>> In the Tracker Capture form, this attribute is showing up with
>>>>>>> scrambled
>>>>>>> radio buttons:
>>>>>>>
>>>>>>> 1. There are three buttons instead of 2
>>>>>>> 2. The words "value" and "yes" is displaying just underneath the
>>>>>>> radio buttons.
>>>>>>>
>>>>>>> Screenshot has been sent to Abyot.
>>>>>>>
>>>>>>> ** Affects: dhis2
>>>>>>>      Importance: Undecided
>>>>>>>          Status: New
>>>>>>>
>>>>>>> --
>>>>>>> You received this bug notification because you are a member of DHIS 2
>>>>>>> developers, which is subscribed to DHIS.
>>>>>>> https://bugs.launchpad.net/bugs/1567905
>>>>>>>
>>>>>>> Title:
>>>>>>>   Tracker Capture - Attribute Yes/No display error
>>>>>>>
>>>>>>> Status in DHIS:
>>>>>>>   New
>>>>>>>
>>>>>>> Bug description:
>>>>>>>   Using the latest version of 2.21 (8 April 2016), we have defined
>>>>>>> one
>>>>>>>   attribute called "Driver's License" as have data type Yes/No.
>>>>>>>
>>>>>>>   In the Tracker Capture form, this attribute is showing up with
>>>>>>>   scrambled radio buttons:
>>>>>>>
>>>>>>>   1. There are three buttons instead of 2
>>>>>>>   2. The words "value" and "yes" is displaying just underneath the
>>>>>>> radio buttons.
>>>>>>>
>>>>>>>   Screenshot has been sent to Abyot.
>>>>>>>
>>>>>>> To manage notifications about this bug go to:
>>>>>>> https://bugs.launchpad.net/dhis2/+bug/1567905/+subscriptions
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> Mailing list: https://launchpad.net/~dhis2-devs
>>>>>>> Post to     : dhis2-devs@xxxxxxxxxxxxxxxxxxx
>>>>>>> Unsubscribe : https://launchpad.net/~dhis2-devs
>>>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>>
>>>>> *******************************************
>>>>>
>>>>> Calle Hedberg
>>>>>
>>>>> 46D Alma Road, 7700 Rosebank, SOUTH AFRICA
>>>>>
>>>>> Tel/fax (home): +27-21-685-6472
>>>>>
>>>>> Cell: +27-82-853-5352
>>>>>
>>>>> Iridium SatPhone: +8816-315-19119
>>>>>
>>>>> Email: calle.hedberg@xxxxxxxxx
>>>>>
>>>>> Skype: calle_hedberg
>>>>>
>>>>> *******************************************
>>>>>
>>>>>
>>>>
>>>
>>>
>>> --
>>>
>>> *******************************************
>>>
>>> Calle Hedberg
>>>
>>> 46D Alma Road, 7700 Rosebank, SOUTH AFRICA
>>>
>>> Tel/fax (home): +27-21-685-6472
>>>
>>> Cell: +27-82-853-5352
>>>
>>> Iridium SatPhone: +8816-315-19119
>>>
>>> Email: calle.hedberg@xxxxxxxxx
>>>
>>> Skype: calle_hedberg
>>>
>>> *******************************************
>>>
>>>
>>
>
>
> --
>
> *******************************************
>
> Calle Hedberg
>
> 46D Alma Road, 7700 Rosebank, SOUTH AFRICA
>
> Tel/fax (home): +27-21-685-6472
>
> Cell: +27-82-853-5352
>
> Iridium SatPhone: +8816-315-19119
>
> Email: calle.hedberg@xxxxxxxxx
>
> Skype: calle_hedberg
>
> *******************************************
>
>


-- 

*******************************************

Calle Hedberg

46D Alma Road, 7700 Rosebank, SOUTH AFRICA

Tel/fax (home): +27-21-685-6472

Cell: +27-82-853-5352

Iridium SatPhone: +8816-315-19119

Email: calle.hedberg@xxxxxxxxx

Skype: calle_hedberg

*******************************************

PNG image

PNG image

PNG image


Follow ups

References