dhis2-devs team mailing list archive

[Morten Olav Hansen <morten@xxxxxxxxx>]

Hi

Thanks for the patch, I have applied it now, I ended up change 2.22/2.23 to
be equal, and applied your trunk patch to trunk only.

-- 
Morten Olav Hansen
Senior Engineer, DHIS 2
University of Oslo
http://www.dhis2.org

On Thu, May 19, 2016 at 7:07 PM, jhansi <jhansirk@xxxxxxxxxxxxxxxx> wrote:

> Hello Dhis-Devs,
>
> After upgrading from DHIS v2.19 to v2.22, we noticed a considerable
> difference in the response size of the following APIs:
>
>    - GET completeDataSetRegistrations
>    - GET dataApprovals/status
>
> Since those APIs were not supporting the fields filter, we were not able
> to reduce the response size. So, we have gone ahead and added the fields
> filter for those APIs but then, we noticed that after adding the filter the
> default response of the API changes and the response is smaller in size. As
> we don’t want the response to change because of the filter addition, we
> have gone ahead and changed the default response to match as it was before.
>
> First we came up with a patch (apiChanges.patch) which includes the fields
> filter and the response is unchanged (same as what it used to be before in
> v2.22), but then, we felt this patch to be very specific to v2.22, so, we
> came up with an other patch (apiChangesTrunk.patch) which also includes the
> fields filter but the response is smaller. (similar to what it used to be
> in v2.21)
>
> Can you please verify the patches and let us know if it can be merged into
> the respective branches or please let us know if you want us to do any
> other modifications.
>
> Attached are the patch files.
>
> Thanks,
> Prachi/Jhansi
>
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~dhis2-devs
> Post to     : dhis2-devs@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~dhis2-devs
> More help   : https://help.launchpad.net/ListHelp
>
>