← Back to team overview

dhis2-devs team mailing list archive

Re: Unique tracked entity attributes are now compulsory?

 

Hi there,

seems we agree, just wanted to add that we should always trim blank values
to null before storing, and nulls are not in conflict with uniqueness.

Lars


On Fri, Jun 10, 2016 at 7:29 AM, Abyot Asalefew Gizaw <abyot@xxxxxxxxx>
wrote:

> Hi,
>
> I think I missed that it was not required from the server side api ... it
> is easy to fix from the client side.
>
> --
> Abyot A. Gizaw.
> Senior Engineer, DHIS2
> University of Oslo
> http://www.dhis2.org
>
> On Fri, Jun 10, 2016 at 4:59 AM, Jose Garcia Muñoz <josemp10@xxxxxxxxx>
> wrote:
>
>>
>> Hi guys,
>>
>> any agreements on this? :)
>>
>>  I would like to know if I need to change the configuration of some
>> programs (unique attributes are always compulsory)  or not (unique
>> attributes can be optional). I would prefer if we can keep them blank as
>> well (so they are optional).
>>
>> Thanks
>> Jose
>>
>> On Wed, Jun 8, 2016 at 10:52 AM, Rodolfo Melia <rmelia@xxxxxxxxxxxx>
>> wrote:
>>
>>> I just want to support the idea that blanks should be accepted and not
>>> checked for uniqueness. I'm glad to hear that the API already supports
>>> this, so it will be great if the UI follows that logic.
>>>
>>> *Rodolfo *
>>>
>>>
>>> On 8 June 2016 at 10:49, Juan Manuel Alcantara Acosta <
>>> jmalcantara1@xxxxxxxxx> wrote:
>>>
>>>> Hi Markus
>>>> I had a short email exchange with Abyot last week and he said the same
>>>> "So many blanks can not be unique” but for a value to be unique there must
>>>> be a value. If the database and the API do not have this requirement, the
>>>> interface should follow the program’s configuration.
>>>> Best regards,
>>>> JM
>>>>
>>>>
>>>>
>>>>
>>>> El 08/06/2016, a las 8:35 a.m., Markus Bekken <markus.bekken@xxxxxxxxx>
>>>> escribió:
>>>>
>>>> Hi guys!
>>>> Chiming in - I think Abyot is on leave today.
>>>> This seems to be a discrepancy that we should just resolve one way or
>>>> the other. You might say that a blank value is not unique, but I have also
>>>> recently encountered a use case where we needed a non-compulsory unique
>>>> attribute like you Jose.
>>>>
>>>> Hiding the field with program rules was a workaround in our case, but I
>>>> think it makes sense to allow blank values in non-compulsory unique
>>>> attributes.
>>>>
>>>> Unless there is any disagreements we can implement the client to
>>>> conform to the API.
>>>>
>>>> Markus
>>>>
>>>> 8. jun. 2016 kl. 09.15 skrev Morten Olav Hansen <morten@xxxxxxxxx>:
>>>>
>>>> Hi
>>>>
>>>> Sorry for late reply, but I have been looking into this, and from the
>>>> backend this is not required. I'm adding in Abyot, hopefully he can answer
>>>> why it is required in the UI part (I see it's marked with red star, and it
>>>> will not allow it without a value)
>>>>
>>>> --
>>>> Morten Olav Hansen
>>>> Senior Engineer, DHIS 2
>>>> University of Oslo
>>>> http://www.dhis2.org
>>>>
>>>> On Mon, Jun 6, 2016 at 12:02 PM, Jose Garcia Muñoz <josemp10@xxxxxxxxx>
>>>> wrote:
>>>>
>>>>>
>>>>> Dear devs,
>>>>>
>>>>> we realized that tracked attributes are always compulsory even if they
>>>>> are not marked like that in the program definition? so it is not possible
>>>>> at all to keep them blank using the Tracker Capture.
>>>>>
>>>>> In PSI (and I guess is the same for many different countries), we need
>>>>> to define unique patient's IDs, although several times it is not possible
>>>>> to collect them for many reasons, but now the system is not giving us the
>>>>> option of keeping the IDs blank
>>>>>
>>>>> Is this something that can be changed? Unique attributes can be
>>>>> compulsory just marking the attribute as compulsory in the program
>>>>> definition...
>>>>>
>>>>> Please, let us know, as we may need to reconsider some
>>>>> re-configuration for our programs.
>>>>>
>>>>> Many Thanks
>>>>> Jose
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> Mailing list: https://launchpad.net/~dhis2-devs
>>>>> Post to     : dhis2-devs@xxxxxxxxxxxxxxxxxxx
>>>>> Unsubscribe : https://launchpad.net/~dhis2-devs
>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>
>>>>>
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~dhis2-devs
>>>> Post to     : dhis2-devs@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~dhis2-devs
>>>> More help   : https://help.launchpad.net/ListHelp
>>>>
>>>>
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~dhis2-devs
>>>> Post to     : dhis2-devs@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~dhis2-devs
>>>> More help   : https://help.launchpad.net/ListHelp
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~dhis2-devs
>>>> Post to     : dhis2-devs@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~dhis2-devs
>>>> More help   : https://help.launchpad.net/ListHelp
>>>>
>>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~dhis2-devs
>>> Post to     : dhis2-devs@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~dhis2-devs
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~dhis2-devs
>> Post to     : dhis2-devs@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~dhis2-devs
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~dhis2-devs
> Post to     : dhis2-devs@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~dhis2-devs
> More help   : https://help.launchpad.net/ListHelp
>
>


-- 
Lars Helge Øverland
Lead developer, DHIS 2
University of Oslo
Skype: larshelgeoverland
lars@xxxxxxxxx
http://www.dhis2.org <https://www.dhis2.org/>

Follow ups

References