← Back to team overview

dhis2-devs team mailing list archive

Re: Plan for merging in trunk for 2.24

 

Hey Mohammed,

If you ment a pull request on github then yes a pull request would suffice
;)

We can take care of the merging/reviewing of your pull request and
deploying it so it's part of the core product.

Regards,

Mark

On Sat, Jun 18, 2016 at 7:40 AM, Aamer Mohammed <aamerm@xxxxxxxxxxxxxxxx>
wrote:

> Hi Lars,
>
> We also have changes to one of the screens in settings-app, for which the
> source code is in a git repo. I wanted to understand on how to move ahead
> with these changes. I hope that submitting a pull request when we send the
> launchpad details would suffice. Let us know your thoughts on this.
>
> Thanks
> Aamer.
>
> On Fri, Jun 17, 2016 at 4:27 PM, Lars Helge Øverland <lars@xxxxxxxxx>
> wrote:
>
>>
>> Thanks. Projected release date is July 1 (alternatively July 4).
>>
>>
>> Lars
>>
>>
>> On Fri, Jun 17, 2016 at 12:49 PM, Vanya Seth <vanyas@xxxxxxxxxxxxxxxx>
>> wrote:
>>
>>> Awesome. Thanks a lot.
>>>
>>> Will keep you posted.
>>>
>>> Regards
>>> Vanya
>>>
>>> On Fri, Jun 17, 2016 at 4:16 PM, Lars Helge Øverland <lars@xxxxxxxxx>
>>> wrote:
>>>
>>>> Hi Vanya,
>>>>
>>>> that is great. Thanks for the effort.
>>>>
>>>> We have a code freeze on Monday 20th, but we can make an exception for
>>>> this.
>>>>
>>>> Just let us know the link to your branch and when its time for us to
>>>> review the code.
>>>>
>>>> best regards,
>>>>
>>>> Lars
>>>>
>>>>
>>>>
>>>>
>>>> On Fri, Jun 17, 2016 at 12:36 PM, Vanya Seth <vanyas@xxxxxxxxxxxxxxxx>
>>>> wrote:
>>>>
>>>>>
>>>>> Hi Lars and Team,
>>>>>
>>>>> We are closing down on the metadata sync work. We are looking at 22
>>>>> June for being able to finish the remaining pieces.
>>>>>
>>>>> I wanted to understand as to how do we move ahead with the merge into
>>>>> trunk?
>>>>>
>>>>> I see that we can propose for merging with in launchpad itself. Please
>>>>> let know what makes sense and how to go about it?
>>>>>
>>>>> After the merge to trunk, we will continue to test it further and add
>>>>> automation tests( we are working with Jason Pickering for the same).In the
>>>>> event of any bugs that we uncover during that time, would we be able to
>>>>> port those fixes back to trunk?
>>>>>
>>>>> It would be good if you could keep us in loop for the various
>>>>> milestone dates that the  DHIS core team is going through.
>>>>>
>>>>> --
>>>>> With Regards
>>>>> Vanya
>>>>> ThoughtWorks Technologies
>>>>> Hyderabad
>>>>>
>>>>> --Stay Hungry Stay Foolish!!
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Lars Helge Øverland
>>>> Lead developer, DHIS 2
>>>> University of Oslo
>>>> Skype: larshelgeoverland
>>>> lars@xxxxxxxxx
>>>> http://www.dhis2.org <https://www.dhis2.org/>
>>>>
>>>>
>>>
>>>
>>> --
>>> With Regards
>>> ThoughtWorks Technologies
>>> Hyderabad
>>>
>>> --Stay Hungry Stay Foolish!!
>>>
>>
>>
>>
>> --
>> Lars Helge Øverland
>> Lead developer, DHIS 2
>> University of Oslo
>> Skype: larshelgeoverland
>> lars@xxxxxxxxx
>> http://www.dhis2.org <https://www.dhis2.org/>
>>
>>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~dhis2-devs
> Post to     : dhis2-devs@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~dhis2-devs
> More help   : https://help.launchpad.net/ListHelp
>
>


-- 
Regards,


Mark Polak
Software developer, DHIS 2
University of Oslo
http://www.dhis2.org <https://www.dhis2.org/>
mark@xxxxxxxxx

Follow ups

References