dhis2-devs team mailing list archive

[Timothy Harding <tharding@xxxxxxxxxxxxxx>]

Thanks Morten, testing now,

Can you let me know where the <htmlCode> should live? Does it need to be in
there twice, or just the once underneath the <dataEntryForm> tag?

like this:

[image: Inline image 1]
and
[image: Inline image 2]


*Timothy Harding*
Sr. Systems Analyst, BAO Systems
+1 202-536-1541 | tharding@xxxxxxxxxxxxxx | http://www.baosystems.com | Skype:
hardingt@xxxxxxxxx | 2900 K Street, Suite 404, Washington D.C. 20007

On Mon, Aug 22, 2016 at 5:40 AM, Morten Olav Hansen <
1614956@xxxxxxxxxxxxxxxxxx> wrote:

> This should now be fixed in latest 2.23 and up
>
> ** Changed in: dhis2
>        Status: Confirmed => Fix Committed
>
> ** Changed in: dhis2
>        Status: Fix Committed => Fix Released
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1614956
>
> Title:
>   Dataset Import/Export does not affect custom entry form
>
> Status in DHIS:
>   Fix Released
>
> Bug description:
>   A few things going on here:
>
>   TL:DR
>   1. Dataset export does not contain the <dataEntryForms> tag as a child
> <metaData>.
>   2. Dataset uploads with <dataEntryForm> as a child of <dataSet> has no
> effect on the custom form
>   3. Dataset uploads with <dataEntryForms> as a child of <metaData> with
> matching entry under <dataSet> still has no effect on custom form
>
>   Long Form:
>   1. I'm not sure where the intended location of the dataEntryForm custom
> HTML. If it is supposed to live as a child of <dataSet>, then all is fine.
> If it is supposed to live in <dataEntryForms> with a link to it in
> <dataSet> as I suspect, then exporting the dataSet should probably come
> with the <dataEntryForms> even if "Export With Dependencies" is _not_
> checked. It is also strange to see the custom HTML twice when you do export
> with Dependencies. Which one is correct? It can also constrain a
> questionable connection if the custom form is very large, as the xml file
> is now doubled in size.
>
>   2. If I alter an exiting custom form in the <dataSet> section and try
>   to upload the xml for it, it will not have any affect. See the video
>   of this in action and the link to the xml file I'm using to do this on
>   the play demo site. This behavior is the exact same for 2.23, where I
>   first encountered it.
>
>   3. As above, if I alter an exiting custom form in the <dataEntryForms>
>   section of the xml file, and try to upload the xml for it, it will not
>   have any affect. See the video of this in action and the link to the
>   xml file I'm using to do this on the play demo site. This behavior is
>   the exact same for 2.23, where I first encountered it.
>
>   Steps to Reproduce:
>   1. Log in as superuser
>   2. Download the following xml files, alter the name,shortname,code,uid
> and upload to playdemo
>   3. Make a an additional change to the custom form and upload to play
> demo, notice nothing actually changes.
>
>   Without the Entry Form
>   https://drive.google.com/open?id=0B9eJ8PZ_4csMcHlIalZTcUNGWkk
>
>   With the Entry Form
>   https://drive.google.com/open?id=0B9eJ8PZ_4csMRTNHanNYbmJGUFk
>
>   Video In Action:
>   https://drive.google.com/open?id=0B9eJ8PZ_4csMYmtYWnJJN1Rtc2M
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/dhis2/+bug/1614956/+subscriptions
>


** Attachment added: "image.png"
   https://bugs.launchpad.net/bugs/1614956/+attachment/4725764/+files/image.png

** Attachment added: "image.png"
   https://bugs.launchpad.net/bugs/1614956/+attachment/4725765/+files/image.png

** Attachment added: "PastedGraphic-1.png"
   https://bugs.launchpad.net/bugs/1614956/+attachment/4725766/+files/PastedGraphic-1.png

-- 
You received this bug notification because you are a member of DHIS 2
developers, which is subscribed to DHIS.
https://bugs.launchpad.net/bugs/1614956

Title:
  Dataset Import/Export does not affect custom entry form

Status in DHIS:
  Fix Released

Bug description:
  A few things going on here:

  TL:DR
  1. Dataset export does not contain the <dataEntryForms> tag as a child <metaData>.
  2. Dataset uploads with <dataEntryForm> as a child of <dataSet> has no effect on the custom form
  3. Dataset uploads with <dataEntryForms> as a child of <metaData> with matching entry under <dataSet> still has no effect on custom form

  Long Form:
  1. I'm not sure where the intended location of the dataEntryForm custom HTML. If it is supposed to live as a child of <dataSet>, then all is fine. If it is supposed to live in <dataEntryForms> with a link to it in <dataSet> as I suspect, then exporting the dataSet should probably come with the <dataEntryForms> even if "Export With Dependencies" is _not_ checked. It is also strange to see the custom HTML twice when you do export with Dependencies. Which one is correct? It can also constrain a questionable connection if the custom form is very large, as the xml file is now doubled in size.

  2. If I alter an exiting custom form in the <dataSet> section and try
  to upload the xml for it, it will not have any affect. See the video
  of this in action and the link to the xml file I'm using to do this on
  the play demo site. This behavior is the exact same for 2.23, where I
  first encountered it.

  3. As above, if I alter an exiting custom form in the <dataEntryForms>
  section of the xml file, and try to upload the xml for it, it will not
  have any affect. See the video of this in action and the link to the
  xml file I'm using to do this on the play demo site. This behavior is
  the exact same for 2.23, where I first encountered it.

  Steps to Reproduce:
  1. Log in as superuser
  2. Download the following xml files, alter the name,shortname,code,uid and upload to playdemo
  3. Make a an additional change to the custom form and upload to play demo, notice nothing actually changes.

  Without the Entry Form
  https://drive.google.com/open?id=0B9eJ8PZ_4csMcHlIalZTcUNGWkk

  With the Entry Form
  https://drive.google.com/open?id=0B9eJ8PZ_4csMRTNHanNYbmJGUFk

  Video In Action:
  https://drive.google.com/open?id=0B9eJ8PZ_4csMYmtYWnJJN1Rtc2M

To manage notifications about this bug go to:
https://bugs.launchpad.net/dhis2/+bug/1614956/+subscriptions