← Back to team overview

dhis2-users team mailing list archive

Re: Status of ImportSummaries in /api/events

 

Ok sounds good.

Regards
Vanya

On Thu, May 12, 2016 at 3:44 PM, Morten Olav Hansen <morten@xxxxxxxxx>
wrote:

> Hi Vanya
>
> Yes, I agree it's not correct. I just want to wait for feedback from Abyot
> or Markus before I change anything, so it won't break EC/TC.
>
> --
> Morten Olav Hansen
> Senior Engineer, DHIS 2
> University of Oslo
> http://www.dhis2.org
>
> On Thu, May 12, 2016 at 4:51 PM, henri claude moungui <
> henrimoungui@xxxxxxxx> wrote:
>
>> Hi all.
>> wasn't the Dry Run option at "yes" ?
>> If this is the case, maybe after resolving the conflict of the  category
>> option identifier: U8vu31ybiD5 , Aamer will have to retry by setting the
>> Dry Run at "No"
>>
>> Hope this helps...if I'm not out of the lines..
>>
>> Henri
>>
>>
>>
>>
>> Le Jeudi 12 mai 2016 10h33, Vanya Seth <vanyas@xxxxxxxxxxxxxxxx> a écrit
>> :
>>
>>
>> Hi Morten
>>
>> As mentioned earlier. We are working on the events data sync. And this
>> specific issue is in the /events POST API.
>>
>> The idea is to retry the event data sync if there is any conflict (where
>> essentially some data has not sycned ). Treating a CONFLICT as a SUCCESS
>> does not sound like a good idea.
>>
>> Apart from that would the /api/events POST be able to update the same
>> event again if retried. Am coming probably from the
>> "attributecategoryoptioncomboid" field.
>>
>> Regards
>> Vanya
>>
>> On Thu, May 12, 2016 at 12:26 PM, Morten Olav Hansen <morten@xxxxxxxxx>
>> wrote:
>>
>> No, I mean for the new DXF2 importer, I'm sorry (I assume you are also
>> working on the metadata sync importer). The event importer has not had any
>> changes done.
>>
>> --
>> Morten Olav Hansen
>> Senior Engineer, DHIS 2
>> University of Oslo
>> http://www.dhis2.org
>>
>> On Thu, May 12, 2016 at 1:44 PM, Aamer Mohammed <aamerm@xxxxxxxxxxxxxxxx>
>> wrote:
>>
>> Thanks Morten for the insight. But we are also on a branch forked off on
>> 2.23 and it is not giving any WARNING kind of status in our case. Any
>> thoughts please?
>>
>>
>> On Thu, May 12, 2016 at 11:46 AM, Morten Olav Hansen <morten@xxxxxxxxx>
>> wrote:
>>
>> Hi
>>
>> I agree this is confusing, but I think this is also the case in our old
>> importer. I'm not sure if we want to change it at this point (as we don't
>> want to break any third party clients out there).
>>
>> That said, as you might know, we changed the approach a bit in our new
>> importer, and it is much better at these kind of issues (in your case it
>> would give status=WARNING which means please have a closer look at the
>> report, or ERROR if all failed).
>>
>> We are hoping to have proper web-api versioning coming in 2.24, which
>> means we can potentially clean up these kinds of issues (but that part is
>> not started yet, so let's see).
>>
>> @Abyot: are you using this returned status for anything in your EC/TC
>> apps?
>>
>> --
>> Morten Olav Hansen
>> Senior Engineer, DHIS 2
>> University of Oslo
>> http://www.dhis2.org
>>
>> On Thu, May 12, 2016 at 12:52 PM, Aamer Mohammed <aamerm@xxxxxxxxxxxxxxxx
>> > wrote:
>>
>> Hi
>>
>> We are using /api/events to post event related data and it is being
>> uploaded successfully. The api returns a response of type ImportSummaries
>> which has the status of ImportSummary along with the count of data which is
>> imported/updated.
>> In case of any conflicts being reported in ImportSummary, we observe that
>> the status still shows as SUCCESS.
>>
>> ---------
>> ImportSummaries {
>> importSummaries = [ImportSummary {
>> status = SUCCESS,
>>                 description = 'null',
>>                 importCount = [imports = 2, updates = 0, ignores = 0],
>>                 conflicts = [ImportConflict {
>> object = 'Illegal category option identifier: U8vu31ybiD5', value =
>>   'U8vu31ybiD5' }],
>>                 dataSetComplete = 'null',
>>                 reference = 'jLBehWyIspM',
>>                 href = '
>> http://msfocamdsynchq.twhosted.com/api/events/jLBehWyIspM'
>> }]
>> }
>> ----------
>> Is this not an error because the complete import of the event data has
>> not happened. Please suggest.
>>
>> Thanks
>> Aamer.
>>
>>
>>
>>
>>
>>
>>
>> --
>> With Regards
>> ThoughtWorks Technologies
>> Hyderabad
>>
>> --Stay Hungry Stay Foolish!!
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~dhis2-users
>> Post to    : dhis2-users@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~dhis2-users
>> More help  : https://help.launchpad.net/ListHelp
>>
>>
>>
>


-- 
With Regards
ThoughtWorks Technologies
Hyderabad

--Stay Hungry Stay Foolish!!

Follow ups

References