← Back to team overview

dhis2-users team mailing list archive

Re: Cant not create new approval levels in 2.26

 

Thanks Jim, just confirming for everyone else this is now fixed in 2.26
core as well. I assume someone pushed the fix from somewhere other than
github then.

On Fri, Nov 10, 2017 at 8:37 PM, Jim Grace <jim@xxxxxxxxx> wrote:

> Birk Johansson made the fix, after I determined that the fix needed to be
> done in the front end code. Now that we're migrating the user interface to
> apps, they're in separate repositories. I see the 2.27 fix in the
> settings-app repository at https://github.com/dhis2/settings-app/commit/
> 8747d606029cb510f178cf86005acf33cc9e0a7c. I'm not sure where the 2.26 fix
> is, but I rebuilt the latest 2.26 on my system and it worked. If you have
> further questions about the fix, Birk might be able to shed more light on
> it.
>
> Cheers,
> Jim
>
>
> On Fri, Nov 10, 2017 at 11:58 AM, Jasper Timm <jasper.timm@ehealthnigeria.
> org> wrote:
>
>> Hi Jim,
>>
>> I can't seem to see the commit for this fix in the 2.26 or 2.27 branch on
>> the dhis2-core repo in github.
>>
>> Did you commit somewhere else?
>>
>> Thanks,
>>
>> - Jasper
>>
>> On Mon, Nov 6, 2017 at 11:48 PM, Ibrahim Bayoh <
>> ibrahim.bayoh@xxxxxxxxxxxxxxxxxxxx> wrote:
>>
>>> thanks, Jim. You are a lifesaver. I'll test and get back to you.
>>>
>>> Best,
>>> Bayoh.
>>>
>>> On Mon, Nov 6, 2017 at 8:43 PM Jim Grace <jim@xxxxxxxxx> wrote:
>>>
>>>> It's fixed now in the latest builds of 2.26 and 2.27. Apologies for the
>>>> long delay.
>>>>
>>>> Cheers,
>>>> Jim
>>>>
>>>>
>>>> On Thu, Nov 2, 2017 at 5:30 AM, Ibrahim Bayoh <
>>>> ibrahim.bayoh@xxxxxxxxxxxxxxxxxxxx> wrote:
>>>>
>>>>> Thanks, Jim
>>>>> It seems like this issue has been around for a while. When do you
>>>>> think we'll get a fix for it?
>>>>> Thanks,
>>>>> Bayoh.
>>>>>
>>>>> On Thu, Oct 26, 2017 at 1:27 PM Trøyel Nerbø <troyel.nerbo@xxxxxx>
>>>>> wrote:
>>>>>
>>>>>> FYI: I also reported this in June. https://jira.dhis2.org/browse/
>>>>>> DHIS2-1831?jql=issuetype%20%3D%20Bug%20AND%20text%20~%20approval
>>>>>>
>>>>>>
>>>>>>
>>>>>> *From:* Dhis2-users [mailto:dhis2-users-bounces+troyel.nerbo=
>>>>>> nrc.no@xxxxxxxxxxxxxxxxxxx] *On Behalf Of *Jim Grace
>>>>>> *Sent:* torsdag 26. oktober 2017 14.18
>>>>>> *To:* Ibrahim Bayoh <ibrahim.bayoh@xxxxxxxxxxxxxxxxxxxx>
>>>>>> *Cc:* dhis2-users <dhis2-users@xxxxxxxxxxxxxxxxxxx>
>>>>>> *Subject:* Re: [Dhis2-users] Cant not create new approval levels in
>>>>>> 2.26
>>>>>>
>>>>>>
>>>>>>
>>>>>> Hi Bayoh,
>>>>>>
>>>>>>
>>>>>>
>>>>>> I have reproduced this problem in 2.26 and 2.27. I have created a
>>>>>> Jira ticket for this at https://jira.dhis2.org/browse/DHIS2-2449.
>>>>>>
>>>>>>
>>>>>>
>>>>>> Apologies for this problem. Thank you for bringing this to our
>>>>>> attention. We will fix it.
>>>>>>
>>>>>>
>>>>>>
>>>>>> Cheers,
>>>>>>
>>>>>> Jim
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Thu, Oct 26, 2017 at 7:30 AM, Ibrahim Bayoh <
>>>>>> ibrahim.bayoh@xxxxxxxxxxxxxxxxxxxx> wrote:
>>>>>>
>>>>>> Hi All,
>>>>>>
>>>>>> Am trying to create approval level in 2.26 which failed on saving
>>>>>> level. Console error reveals a "Missing required property 'name' " error.
>>>>>> See screenshots below.
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Bayoh.
>>>>>>
>>>>>>
>>>>>>
>>>>>> [image: Screen Shot 2017-10-26 at 11.10.35 AM.png]
>>>>>>
>>>>>> [image: Screen Shot 2017-10-26 at 11.26.10 AM.png]
>>>>>>
>>>>>> --
>>>>>>
>>>>>> Ibrahim Bayoh
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> Mailing list: https://launchpad.net/~dhis2-users
>>>>>> Post to     : dhis2-users@xxxxxxxxxxxxxxxxxxx
>>>>>> Unsubscribe : https://launchpad.net/~dhis2-users
>>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>>
>>>>>> Jim Grace
>>>>>>
>>>>>> Core developer, DHIS 2
>>>>>>
>>>>>> HISP US Inc.
>>>>>>
>>>>>> http://www.dhis2.org <https://www.dhis2.org/>
>>>>>>
>>>>> --
>>>>> Ibrahim Bayoh
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Jim Grace
>>>> Core developer, DHIS 2
>>>> HISP US Inc.
>>>> http://www.dhis2.org <https://www.dhis2.org/>
>>>>
>>> --
>>> Ibrahim Bayoh
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~dhis2-users
>>> Post to     : dhis2-users@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~dhis2-users
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>>
>>
>>
>> --
>>
>> *Jasper Timm*
>>
>> Lead Software Developer
>>
>> *eHealth Africa*
>>
>> Mobile +232 99891119 <+23299891119>
>>
>> www.ehealthafrica.org
>>
>>
>> <http://www.ehealthafrica.org/>
>>
>>
>
>
> --
> Jim Grace
> Core developer, DHIS 2
> HISP US Inc.
> http://www.dhis2.org <https://www.dhis2.org/>
>



-- 

*Jasper Timm*

Lead Software Developer

*eHealth Africa*

Mobile +232 99891119 <+23299891119>

www.ehealthafrica.org


<http://www.ehealthafrica.org/>

References