← Back to team overview

divmod-dev team mailing list archive

Re: [Merge] lp:~divmod-dev/divmod.org/nevow-json into lp:divmod.org

 

Review: Approve
Looks good! (I would say "Please merge", but I'm about to set the merge proposal to Approved, which I expect means the same thing)

One thing does occur to me: if you have a reference handy documenting the characters that need to be escaped, it might be useful leaving it in a comment near this code for anyone trying to make sense of it later on.
-- 
https://code.launchpad.net/~divmod-dev/divmod.org/nevow-json/+merge/66843
Your team Divmod-dev is subscribed to branch lp:divmod.org.


References