divmod-dev team mailing list archive

Thread
Date

Re: lp:~divmod-dev/divmod.org/811792-different-metadata-approach into lp:divmod.org

To: Tristan Seligmann <mithrandi@xxxxxxxxxxxxx>
From: Jean-Paul Calderone <exarkun@xxxxxxxxxxxxxxxxx>
Date: Mon, 12 Sep 2011 21:43:22 -0000
In-reply-to: <20110806180638.6065.28252.launchpad@loganberry.canonical.com>
Reply-to: mp+70655@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

True that the patch has no unit tests, and there appears to be no direct test coverage for some of these attributes.  However, considering the history and likely future of formless, I'm not going to object to the change as-is.  If someone is using formless and finds a problem with this change, they're welcome to contribute some new unit tests.  Meanwhile, the code is at least executed by the existing test suite, and all of the tests pass, so I think it's great, please merge.

-- 
https://code.launchpad.net/~divmod-dev/divmod.org/811792-different-metadata-approach/+merge/70655
Your team Divmod-dev is subscribed to branch lp:divmod.org.

References

[Merge] lp:~divmod-dev/divmod.org/811792-different-metadata-approach into lp:divmod.org
From: Tristan Seligmann, 2011-08-06