← Back to team overview

divmod-dev team mailing list archive

[Merge] lp:~exarkun/divmod.org/spambayes-hammie-args into lp:divmod.org

 

Jean-Paul Calderone has proposed merging lp:~exarkun/divmod.org/spambayes-hammie-args into lp:divmod.org.

Requested reviews:
  Divmod-dev (divmod-dev)
Related bugs:
  Bug #994287 in Quotient: "SpamBayes broken, TypeError when adding."
  https://bugs.launchpad.net/quotient/+bug/994287

For more details, see:
https://code.launchpad.net/~exarkun/divmod.org/spambayes-hammie-args/+merge/117268

Pass new required `mode` argument to spambayes.hammie.Hammie initializer.  Makes existing unit tests pass again.  Backwards incompatible with older versions of spambayes.

-- 
https://code.launchpad.net/~exarkun/divmod.org/spambayes-hammie-args/+merge/117268
Your team Divmod-dev is requested to review the proposed merge of lp:~exarkun/divmod.org/spambayes-hammie-args into lp:divmod.org.
=== modified file 'Quotient/xquotient/spam.py'
--- Quotient/xquotient/spam.py	2009-07-16 00:52:55 +0000
+++ Quotient/xquotient/spam.py	2012-07-30 13:34:20 +0000
@@ -393,7 +393,7 @@
             log.err()
             c = classifier.Classifier()
         self.classifier = c
-        self.guesser = hammie.Hammie(c)
+        self.guesser = hammie.Hammie(c, mode='r')
 
 
     # IHamFilter
@@ -432,7 +432,7 @@
         if p.exists():
             p.remove()
             self.classifier = classifier.Classifier()
-            self.guesser = hammie.Hammie(self.classifier)
+            self.guesser = hammie.Hammie(self.classifier, mode='r')
 
 
 item.declareLegacyItem(SpambayesFilter.typeName, 1, dict(


Follow ups