divmod-dev team mailing list archive

[Tristan Seligmann <mithrandi@xxxxxxxxxxxxx>]

Review: Needs Fixing

Insofar as I understand anything that is happening in this code, the changes look reasonable. I have a few minor points:

1. xquotient.spam._SQLite3Classifier

1.1. SCHEMA is not documented in the class docstring.

1.2. The way the nspam and nham properties are defined loses the docstring. This isn't terribly important, perhaps, but it would be nice to have it available for runtime introspection.

2. xquotient.test.test_spambayes.SpambayesFilterTestCase has a handful of "XXX" comments; these should probably be turned into bug report(s).
-- 
https://code.launchpad.net/~exarkun/divmod.org/database-classifier-persistence/+merge/120231
Your team Divmod-dev is subscribed to branch lp:divmod.org.