← Back to team overview

divmod-dev team mailing list archive

Re: [Merge] lp:~jml/divmod.org/pyflakes-reporter into lp:divmod.org

 

Sorry about the partial reply.

0. Reporter moved to new module, pyflakes.reporter.
1. Not sure these can be combined into one method while still preserving current output. e.g. IOError doesn't include filename. TODO: Investigate further, try a couple of options.
2. TODO
3. Done, but for tests only.  AFAICT, only the tests import Twisted.  Happy to change non-test code if you don't mind having it depend on Twisted.
4. Docstrings added
5. My pleasure.
6. I've killed subprocess.Popen usage. Made an ugly compromise for spawning a subprocess and sending stdin.  Think it's the least of four evils (the other three being continue w/ subprocess.Popen, duplicate _EverythingGetter in pyflakes, or block this branch until Twisted provides such a helper). 
-- 
https://code.launchpad.net/~jml/divmod.org/pyflakes-reporter/+merge/113857
Your team Divmod-dev is subscribed to branch lp:divmod.org.


References