divmod-dev team mailing list archive

[Jean-Paul Calderone <exarkun@xxxxxxxxxxxxxxxxx>]

Review: Needs Fixing

Hiya.  This is an error that a lot of people come across.  It's been reported at least three times, even. :)  It's somewhat tricky to resolve, though.  For example, the change proposed here makes pyflakes stop reporting the error in this code:

    try:
        pass
    except ImportError:
        import foo
        import bar as foo
    print foo

Some amount of care is needed in implementing this to ensure that at least existing functionality is preserved.  Beyond that, it's probably also necessary to handle quite a variety of variations on this error.  The later can be addressed incrementally, at least, but it's really necessary to keep the former in mind at every stage.

-- 
https://code.launchpad.net/~dobey/divmod.org/pyflakes-less-redef/+merge/130183
Your team Divmod-dev is subscribed to branch lp:divmod.org.