divmod-dev team mailing list archive

[Glyph Lefkowitz <glyph@xxxxxxxxxxxxxxxxx>]

Review: Approve awesome

1. Does nevow have continuous integration someplace? I'd love to see a green buildbot.

2. "# ugly :(" isn't really documentation. It'd be nice for there to be a function in the test module that actually does the private-attribute mangling so we could change the implementation later and so you could hang a docstring.

3. Does this change the required Twisted version?  If so please document.

Other than #3, don't let this stop you from landing.
-- 
https://code.launchpad.net/~exarkun/divmod.org/nevow-test-fixes/+merge/141498
Your team Divmod-dev is subscribed to branch lp:divmod.org.