divmod-dev team mailing list archive

[Tristan Seligmann <mithrandi@xxxxxxxxxxxxx>]

Review: Needs Fixing

This basically looks good, I only have two trivial things to comment on:

8	-
9	aggregateInterfaces = {
10	IService: serviceSpecialCase,
11	- IServiceCollection: serviceSpecialCase}
12	+ IServiceCollection: serviceSpecialCase
13	+ }

Instead of getting into a convoluted discussion about coding style, I'll just suggest that since you're not otherwise changing this code, the formatting should be left as-is.

36	+ # adapt every popwerup to IPowerupIndirector, calling this method.

Typo: "popwerup" -> "powerup"
-- 
https://code.launchpad.net/~lvh/divmod.org/storeless-conform-1118498/+merge/148490
Your team Divmod-dev is subscribed to branch lp:divmod.org.