divmod-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~exarkun/divmod.org/actions-commands-1189159 into lp:divmod.org

To: Jean-Paul Calderone <exarkun@xxxxxxxxxxxxxxxxx>
From: Jonathan Jacobs <jonathan+launchpad@xxxxxxxxxxx>
Date: Thu, 04 Jul 2013 09:35:33 -0000
In-reply-to: <20130609182423.20488.20768.launchpad@ackee.canonical.com>
Reply-to: mp+168297@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Perhaps this is obvious to someone who is more involved with Imaginary than I am, but why should players be thinking in terms of actions? Neither the docstring, command help, nor the command reply go into any detail. I'm wondering if they should, if so then filing a new bug for the documentation task would be okay.

As far as the actual code goes I'd say it looks good.
-- 
https://code.launchpad.net/~exarkun/divmod.org/actions-commands-1189159/+merge/168297
Your team Divmod-dev is subscribed to branch lp:divmod.org.

References

[Merge] lp:~exarkun/divmod.org/actions-commands-1189159 into lp:divmod.org
From: Jean-Paul Calderone, 2013-06-09