← Back to team overview

divmod-dev team mailing list archive

Re: [Merge] lp:~exarkun/divmod.org/explained-inventory-1193494 into lp:divmod.org


By no means a review:

 * It looks like "ConceptTemplate" is missing some method docstrings.

 * If the target named in a format string to ConceptTemplate.expand does not exist, KeyError is raised (probably with an unhelpful exception) and if the property of that target (name, pronoun, etc.) does not exist then AttributeError (slightly more useful) is raised; neither of these cases appears in the tests. Custom exceptions for these cases would allow them to be more specific about what went wrong, and perhaps even where.

   I also wonder about the interaction of these exceptions and the rest of the system: if there is a typo in the format string, is the entity simply imperceptible to the viewer.
Your team Divmod-dev is requested to review the proposed merge of lp:~exarkun/divmod.org/explained-inventory-1193494 into lp:divmod.org.