divmod-dev team mailing list archive

[David-Sarah Hopwood <david-sarah@xxxxxxxxxxxxx>]

> This would be an easier change to accept if it included automated test
> coverage.

What would constitute an acceptable testing strategy? Note that in order to run tests you have to successfully build, in which case this code was necessarily executed and returned some version (not necessarily the correct one, admittedly). I suppose you can unit-test the function in {{{setup.py}}} though. Or, you could check that the version returned by {{{pkg_resources}}} is the same as the one you get by importing {{{nevow._version}}} (remember to skip the test if {{{pkg_resources}}} is not importable).

-- 
https://code.launchpad.net/~nejucomo/divmod.org/fix-nevow-setup/+merge/176026
Your team Divmod-dev is subscribed to branch lp:divmod.org.